Poisson returns -1 for small lambda#1284
Merged
dhardy merged 2 commits intorust-random:masterfrom Feb 13, 2023
tearne:poissonknuth
Merged
Poisson returns -1 for small lambda#1284dhardy merged 2 commits intorust-random:masterfrom tearne:poissonknuth
dhardy merged 2 commits intorust-random:masterfrom
tearne:poissonknuth
Conversation
dhardy
approved these changes
Feb 11, 2023
Member
dhardy
left a comment
dhardy
left a comment
There was a problem hiding this comment.
Aha, looks like the condition was tested too soon relative to Knuth's method (usually written do ... while condition).
Contributor
|
Thanks! Could you please also add a bullet point to the |
Contributor
Author
|
Sure. Done. Force-pushed since I had initially branched off 0.4.3 |
benjamin-lieser
pushed a commit
to benjamin-lieser/rand
that referenced
this pull request
Feb 5, 2025
* Correct Knuth's method since not using do-while
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small lambda reveals the current implementation of Knuth's method fails, yielding an output of -1. It can be fixed with different starting values.