Fix redundant import warnings#1405
Merged
dhardy merged 1 commit intorust-random:masterfrom Mar 7, 2024
MichaelOwenDyer:Remove-redundant-imports
Merged
Fix redundant import warnings#1405dhardy merged 1 commit intorust-random:masterfrom MichaelOwenDyer:Remove-redundant-imports
dhardy merged 1 commit intorust-random:masterfrom
MichaelOwenDyer:Remove-redundant-imports
Conversation
dhardy
approved these changes
Mar 7, 2024
Member
dhardy
left a comment
dhardy
left a comment
There was a problem hiding this comment.
Thanks.
MSRV (1.60.0) passes.
The CI failures are due to non_local_definitions on nightly which is a false positive in my opinion; lets leave that as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentrySummary
There are some warnings being thrown in the
test (ubuntu-latest, x86_64-unknown-linux-gnu, nightly, minimal_versions)andtest-miriGitHub actions due to redundant imports. I thought I would go ahead and remove them.