Skip to content

Avoid assertion failure on after(k) or older(k) where k < 1 or k >= 0x80000000UL#4

Merged
sipa merged 1 commit intosipa:masterfrom
practicalswift:avoid-assertion-failure
Sep 4, 2019
Merged

Avoid assertion failure on after(k) or older(k) where k < 1 or k >= 0x80000000UL#4
sipa merged 1 commit intosipa:masterfrom
practicalswift:avoid-assertion-failure

Conversation

@practicalswift
Copy link
Copy Markdown
Contributor

Before:

$ ./miniscript <<< "after(0)"
miniscript: bitcoin/script/miniscript.h:366: miniscript::Type miniscript::Node<Key>::CalcType() const [with Key = std::__cxx11::basic_string<char>]: Assertion `k >= 1 && k < 0x80000000UL' failed.
Aborted
$ ./miniscript <<< "older(0)"
miniscript: bitcoin/script/miniscript.h:366: miniscript::Type miniscript::Node<Key>::CalcType() const [with Key = std::__cxx11::basic_string<char>]: Assertion `k >= 1 && k < 0x80000000UL' failed.
Aborted

After:

$ ./miniscript <<< "after(0)"
Failed to parse as policy or miniscript 'after(0)'
$ ./miniscript <<< "older(0)"
Failed to parse as policy or miniscript 'older(0)'

@sipa
Copy link
Copy Markdown
Owner

sipa commented Sep 4, 2019

ACK!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants