Merged
Conversation
Member
|
It looks good to me. Simple but I like the idea to keep the expression open to any object. I have the feeling that this will open to many formats in the future and could require proper extensions for the expression spec. |
emmanuelmathot
approved these changes
Apr 12, 2021
Member
|
How do we specify that the field can also be used in the |
Contributor
Author
|
Not sure what we decided for, but I think we could either go with the existing field in raster that just re-uses this definition or use processing:expression in the raster extension. The idea was to have a common building block, so both sound good to me. |
Contributor
Author
|
From my side we can merge this... Thoughts? |
Member
|
We can merge |
Contributor
Author
|
Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would be great if someone could check the list of potential formats and add/improve others.