Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Problem
We previously removed some modal blurs because it obscured useful content. This came up again in #13905 because the blur on delete modals hid useful information like which entries you were trying to delete.
What this PR Does
Closes #13905 …
Blurred modals keep causing unintended consequences so I think it's better to default to
blur = offfor confirmation modals, and consciously turn it on when it makes sense.I've updated the confirmation modals so that blur is
offby default and mapped out where to turn them on:Blur ON
components/LicensingAlert.vuecomponents/two-factor/TwoFactor.vuecomponents/modals/ElevatedSessionModal.vuecomponents/two-factor/RecoveryCodesModal.vuecomponents/two-factor/Setup.vuepages/users/Passkeys.vuecomponents/updater/Release.vuecomponents/command-palette/CommandPalette.vueBlur OFF
pages/utilities/Cache.vuecomponents/ui/Listing/CustomizeColumns.vuecomponents/fieldtypes/replicator/SetPicker.vuecomponents/ui/Listing/Presets.vuecomponents/fieldtypes/replicator/Set.vuecomponents/fieldtypes/grid/Grid.vuecomponents/fieldtypes/TableFieldtype.vuecomponents/fieldtypes/ArrayFieldtype.vuecomponents/fieldsets/FieldsetDeleter.vuecomponents/fieldsets/FieldsetResetter.vuecomponents/blueprints/BlueprintResetter.vuecomponents/ResourceDeleter.vuecomponents/collections/DeleteLocalizationConfirmation.vuepages/preferences/nav/Edit.vuecomponents/actions/ConfirmableAction.vuecomponents/assets/Upload.vuecomponents/field-actions/FieldActionModal.vuecomponents/entries/PublishForm.vuecomponents/terms/PublishForm.vuecomponents/globals/PublishForm.vuecomponents/inputs/relationship/InlinePublishForm.vuecomponents/structures/PageEditor.vuecomponents/structures/PageTree.vuecomponents/revision-history/Restore.vuepages/layout/Layout.vuecomponents/assets/Editor/Editor.vuepages/Playground.vueHow to Reproduce