support parallel running of commands#2215

oprudkyi · 2025-10-25T14:29:17Z

What type of PR is this?

Fix to allow running commands in parallel (probably partial)

bug
feature

What this PR does / why we need it:

extra test go test -run 'TestCommand_ParallelRun' -count 100000 -failfast -race
avoid global HelpFlag reuse in different commands by cloning flag
avoid global VersionFlag reuse in different commands
remove globals used for splicing slices and maps
defaultSliceFlagSeparator, disableSliceFlagSeparator, defaultMapFlagKeyValueSeparator converted to consts
command - added new MapFlagKeyValueSeparator field
command fields - SliceFlagSeparator, DisableSliceFlagSeparator, MapFlagKeyValueSeparator are propagated down to FlagBase and then to (MapBase|SliceBase)

Which issue(s) this PR fixes:

Fixes #2176

Special notes for your reviewer:

I just lurked around, so please recheck carefully

Testing

extra test go test -run 'TestCommand_ParallelRun' -count 100000 -failfast -race

Release Notes

Reduced dependency on internal global vars, allows to run commands in parallel

`go test -run 'TestCommand_ParallelRun' -count 100000 -failfast -race`

…ands

- defaultSliceFlagSeparator, disableSliceFlagSeparator, defaultMapFlagKeyValueSeparator converted to consts - command - new MapFlagKeyValueSeparator field

…ommands

command_setup.go

dearchap · 2025-10-26T23:48:19Z

command.go


 func (cmd *Command) set(fName string, f Flag, val string) error {
 	cmd.setFlags[f] = struct{}{}
+	cmd.setMultiValueParsingConfig(f)


strictly speaking this call should be moved into PreParse phase.

Hi @dearchap
I tried to avoid breaking things, and there are two set methods set and Set

Initially I thought to call setMultiValueParsingConfig from inside parseFlags(args Args) (Args, error) { or run(... but found that Set can be called without Run , at least in tests , so I moved it where setMultiValueParsingConfig will be called for sure

flag_map_impl.go

flag.go

Thanks to urfave/cli#2215 we should no longer need this workaround 🎉

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/urfave/cli/v3](https://github.com/urfave/cli) | require | minor | `v3.3.8` -> `v3.6.1` | --- ### Release Notes <details> <summary>urfave/cli (github.com/urfave/cli/v3)</summary> ### [`v3.6.1`](https://github.com/urfave/cli/releases/tag/v3.6.1) [Compare Source](urfave/cli@v3.6.0...v3.6.1) #### What's Changed - chore(deps): bump golangci/golangci-lint-action from 8 to 9 by [@dependabot](https://github.com/dependabot)\[bot] in [#2222](urfave/cli#2222) - feat: add ability to override usage text of default help command by [@Maks1mS](https://github.com/Maks1mS) in [#2196](urfave/cli#2196) - Fix:(issue\_2223) Fix incorrect processing of empty value after = by [@dearchap](https://github.com/dearchap) in [#2224](urfave/cli#2224) #### New Contributors - [@Maks1mS](https://github.com/Maks1mS) made their first contribution in [#2196](urfave/cli#2196) **Full Changelog**: <urfave/cli@v3.6.0...v3.6.1> ### [`v3.6.0`](https://github.com/urfave/cli/releases/tag/v3.6.0) [Compare Source](urfave/cli@v3.5.0...v3.6.0) #### What's Changed - support parallel running of commands by [@oprudkyi](https://github.com/oprudkyi) in [#2215](urfave/cli#2215) - Fix:(issue\_2208) Fix local flag by [@dearchap](https://github.com/dearchap) in [#2211](urfave/cli#2211) - chore(deps): bump the python-packages group with 2 updates by [@dependabot](https://github.com/dependabot)\[bot] in [#2219](urfave/cli#2219) - Call actions on flags set from env by [@malclocke](https://github.com/malclocke) in [#2221](urfave/cli#2221) #### New Contributors - [@malclocke](https://github.com/malclocke) made their first contribution in [#2221](urfave/cli#2221) **Full Changelog**: <urfave/cli@v3.5.0...v3.6.0> ### [`v3.5.0`](https://github.com/urfave/cli/releases/tag/v3.5.0) [Compare Source](urfave/cli@v3.4.1...v3.5.0) #### What's Changed - Update mkdocs reqs by [@meatballhat](https://github.com/meatballhat) in [#2190](urfave/cli#2190) - Allow the user to stop processing flags after seeing N args by [@adrian-thurston](https://github.com/adrian-thurston) in [#2163](urfave/cli#2163) - chore(deps): bump github.com/stretchr/testify from 1.10.0 to 1.11.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#2194](urfave/cli#2194) - chore(deps): bump mkdocs-material from 9.6.16 to 9.6.18 in the python-packages group by [@dependabot](https://github.com/dependabot)\[bot] in [#2195](urfave/cli#2195) - chore(deps): bump actions/setup-go from 5 to 6 by [@dependabot](https://github.com/dependabot)\[bot] in [#2198](urfave/cli#2198) - chore(deps): bump actions/setup-node from 4 to 5 by [@dependabot](https://github.com/dependabot)\[bot] in [#2199](urfave/cli#2199) - chore(deps): bump actions/setup-python from 5 to 6 by [@dependabot](https://github.com/dependabot)\[bot] in [#2200](urfave/cli#2200) - chore(deps): bump github.com/stretchr/testify from 1.11.0 to 1.11.1 by [@dependabot](https://github.com/dependabot)\[bot] in [#2197](urfave/cli#2197) - chore(deps): bump mkdocs-material from 9.6.18 to 9.6.19 in the python-packages group by [@dependabot](https://github.com/dependabot)\[bot] in [#2201](urfave/cli#2201) - chore(deps): bump mkdocs-material from 9.6.19 to 9.6.20 in the python-packages group by [@dependabot](https://github.com/dependabot)\[bot] in [#2202](urfave/cli#2202) - feat: add name of argument into error message when parsing fails by [@oprudkyi](https://github.com/oprudkyi) in [#2203](urfave/cli#2203) - chore(deps): bump mkdocs-material from 9.6.20 to 9.6.21 in the python-packages group by [@dependabot](https://github.com/dependabot)\[bot] in [#2204](urfave/cli#2204) - add space between arguments usage by [@dimfu](https://github.com/dimfu) in [#2207](urfave/cli#2207) - chore(deps): bump mkdocs-material from 9.6.21 to 9.6.22 in the python-packages group by [@dependabot](https://github.com/dependabot)\[bot] in [#2213](urfave/cli#2213) - Fix: Make DefaultText behaviour consistent by [@dearchap](https://github.com/dearchap) in [#2214](urfave/cli#2214) #### New Contributors - [@adrian-thurston](https://github.com/adrian-thurston) made their first contribution in [#2163](urfave/cli#2163) - [@oprudkyi](https://github.com/oprudkyi) made their first contribution in [#2203](urfave/cli#2203) - [@dimfu](https://github.com/dimfu) made their first contribution in [#2207](urfave/cli#2207) **Full Changelog**: <urfave/cli@v3.4.1...v3.5.0> ### [`v3.4.1`](https://github.com/urfave/cli/releases/tag/v3.4.1) [Compare Source](urfave/cli@v3.4.0...v3.4.1) #### What's Changed - Use recommended GitHub Actions runner labels by [@meatballhat](https://github.com/meatballhat) in [#2181](urfave/cli#2181) - chore(deps): bump actions/checkout from 4 to 5 by [@dependabot](https://github.com/dependabot)\[bot] in [#2179](urfave/cli#2179) - Document that `v3` series is recommended for new development by [@meatballhat](https://github.com/meatballhat) in [#2186](urfave/cli#2186) **Full Changelog**: <urfave/cli@v3.4.0...v3.4.1> ### [`v3.4.0`](https://github.com/urfave/cli/releases/tag/v3.4.0) [Compare Source](urfave/cli@v3.3.9...v3.4.0) #### What's Changed - Export help display functions as variables to allow custom help display logic by [@almas-x](https://github.com/almas-x) in [#2150](urfave/cli#2150) - Invoke OnUsageError when missing required flags by [@MohitPanchariya](https://github.com/MohitPanchariya) in [#2161](urfave/cli#2161) - Fix:(issue\_2169) Allow trim space for string slice flags by [@dearchap](https://github.com/dearchap) in [#2171](urfave/cli#2171) - Add example of flag groups to docs by [@jllovet](https://github.com/jllovet) in [#2178](urfave/cli#2178) - Add installation instructions for gfmrun by [@jllovet](https://github.com/jllovet) in [#2177](urfave/cli#2177) - Ensure public vars reference public types by [@meatballhat](https://github.com/meatballhat) in [#2180](urfave/cli#2180) #### New Contributors - [@almas-x](https://github.com/almas-x) made their first contribution in [#2150](urfave/cli#2150) - [@MohitPanchariya](https://github.com/MohitPanchariya) made their first contribution in [#2161](urfave/cli#2161) - [@jllovet](https://github.com/jllovet) made their first contribution in [#2178](urfave/cli#2178) **Full Changelog**: <urfave/cli@v3.3.9...v3.4.0> ### [`v3.3.9`](https://github.com/urfave/cli/releases/tag/v3.3.9) [Compare Source](urfave/cli@v3.3.8...v3.3.9) #### What's Changed - Fix typos in documentation for customizations and full API example by [@amarjit03](https://github.com/amarjit03) in [#2165](urfave/cli#2165) - Update advanced.md by [@thetillhoff](https://github.com/thetillhoff) in [#2170](urfave/cli#2170) #### New Contributors - [@amarjit03](https://github.com/amarjit03) made their first contribution in [#2165](urfave/cli#2165) - [@thetillhoff](https://github.com/thetillhoff) made their first contribution in [#2170](urfave/cli#2170) **Full Changelog**: <urfave/cli@v3.3.8...v3.3.9> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://kubara.git.onstackit.cloud/STACKIT/kubara/pulls/100 Co-authored-by: Matthias_Huether <matthias.huether_ext@external.stackit.cloud> Co-committed-by: Matthias_Huether <matthias.huether_ext@external.stackit.cloud>

oprudkyi added 3 commits October 25, 2025 15:39

feat: test parallel execution of commands

bc9dc5b

`go test -run 'TestCommand_ParallelRun' -count 100000 -failfast -race`

fix: parallel running - avoid global HelpFlag reuse in different comm…

55c8fa4

…ands

fix: parallel running - remove globals used for splicing slices and maps

57bfb1c

- defaultSliceFlagSeparator, disableSliceFlagSeparator, defaultMapFlagKeyValueSeparator converted to consts - command - new MapFlagKeyValueSeparator field

oprudkyi requested a review from a team as a code owner October 25, 2025 14:29

feat: update docs

5be0b1f

oprudkyi force-pushed the issue/parallel_run branch from 120fc33 to 5be0b1f Compare October 25, 2025 14:36

fix: parallel running - avoid global VersionFlag reuse in different c…

53ab291

…ommands

oprudkyi mentioned this pull request Oct 25, 2025

fix: comand cannot be run concurrently goravel/framework#1243

Merged

1 task

dearchap reviewed Oct 25, 2025

View reviewed changes

command_setup.go Outdated Show resolved Hide resolved

dearchap reviewed Oct 25, 2025

View reviewed changes

command_setup.go Show resolved Hide resolved

fix: parallel running - improve clonning of global flags

ff292b2

dearchap reviewed Oct 26, 2025

View reviewed changes

flag_map_impl.go Outdated Show resolved Hide resolved

dearchap reviewed Oct 26, 2025

View reviewed changes

flag.go Outdated Show resolved Hide resolved

fix: parallel running - refactor code

798146b

dearchap approved these changes Oct 28, 2025

View reviewed changes

dearchap merged commit 9dad0d4 into urfave:main Oct 28, 2025
9 checks passed

G-Rath mentioned this pull request Nov 9, 2025

fix(cli): update urfave/cli to address rare race conditions google/osv-scanner#2337

Merged

another-rex pushed a commit to google/osv-scanner that referenced this pull request Nov 12, 2025

fix(cli): update urfave/cli to address rare race conditions (#2337)

3572178

Thanks to urfave/cli#2215 we should no longer need this workaround 🎉

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support parallel running of commands#2215