vlib: io: Buffered IO, x.net -> net#6754
Merged
spytheman merged 31 commits intovlang:masterfrom Nov 15, 2020
Merged
Conversation
6452db9 to
7d36a79
Compare
esquerbatua
approved these changes
Nov 6, 2020
Contributor
|
Great job! |
Member
|
Member
|
Great work @emily33901 ! Looking forward to merging this. |
JalonSolov
reviewed
Nov 8, 2020
And fix everything else around that
In keeping with `none` being used to represent eof, UdpConn and TcpConn return `none` on end of connection
afa34bf to
109a11f
Compare
…nite timeouts to websocket_client.v
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spiritual successor to #6299 This PR Adds buffered io and general purpose interfaces for reading, writing, and a simple buffered reader struct that can be fleshed out more when needed.
Also moves x.net -> net and fixes smtp, ftp, http, x.websocket, and everything else.
read_into is renamed to read to be inline with the Reader interface that itself uses the name from the Go reader interface. Since
io.read_all()can now be used to read any bytes that a reader has I feel that this is fineI think just the vweb test is busted but thats because it does some silly tcpconn opening stuff.