hold fixes

[Duncaen]

This feels more like a workaround, not sure if I get it right.
At least all tests, except one that to me doesn't make a lot of sense pass.
The failing test expects the install to work, but now the install will fail.

Here is the failing xbps-install from the now failing test:

[DEBUG] XBPS: 0.60 API: 20200423 GIT: 46758bf7
[DEBUG] Processing configuration directory: /tmp/kyua.Jp45ok/2/work/some_repo/root/empty.conf
[DEBUG] Processing system configuration directory: /tmp/kyua.Jp45ok/2/work/some_repo/root/usr/local/share/xbps.d
[DEBUG] rootdir=/tmp/kyua.Jp45ok/2/work/some_repo/root
[DEBUG] metadir=/tmp/kyua.Jp45ok/2/work/some_repo/root/var/db/xbps
[DEBUG] cachedir=/tmp/kyua.Jp45ok/2/work/some_repo/root/var/cache/xbps
[DEBUG] confdir=/tmp/kyua.Jp45ok/2/work/some_repo/root/empty.conf
[DEBUG] sysconfdir=/tmp/kyua.Jp45ok/2/work/some_repo/root/usr/local/share/xbps.d
[DEBUG] syslog=true
[DEBUG] bestmatching=false
[DEBUG] keepconf=false
[DEBUG] Architecture: x86_64
[DEBUG] Target Architecture: (null)
[DEBUG] Repository[0]=/tmp/kyua.Jp45ok/2/work/some_repo
[DEBUG] [pkgdb] added vpkg pkgdep-21_1 for pkgheld
[DEBUG] [pkgdb] initialized ok.
[DEBUG] [rpool] checking `/tmp/kyua.Jp45ok/2/work/some_repo' at index 0
[DEBUG] [repo] `/tmp/kyua.Jp45ok/2/work/some_repo/x86_64-stagedata' open stagedata No such file or directory
[DEBUG] [rpool] `/tmp/kyua.Jp45ok/2/work/some_repo' registered.
[DEBUG] xbps_repo_get_pkg: found pkginst-1.0_1
[DEBUG] [trans] `pkginst-1.0_1' stored (/tmp/kyua.Jp45ok/2/work/some_repo)
[DEBUG] xbps_transaction_install_pkg: trans_find_pkg pkginst: 0
[DEBUG] xbps_transaction_prepare: processing deps
[DEBUG] Finding required dependencies for 'pkginst-1.0_1':
[DEBUG] pkginst-1.0_1: requires dependency 'pkgdep-22_1': [DEBUG] vpkg_user_conf: vpkg_conf pkgdep-21_1 pkg pkgheld vpkgname pkgdep
[DEBUG] vpkg_user_conf: vpkg_conf pkgdep-21_1 pkg pkgheld vpkgname pkgdep
not installed `pkgheld-1.17.4_2 (vpkg)' on hold state! ignoring package.
[DEBUG] `pkgdep-22_1' added into the missing deps array.
[DEBUG] xbps_transaction_prepare: checking on hold pkgs
[DEBUG] xbps_transaction_prepare: checking replaces
[DEBUG] xbps_transaction_prepare: checking revdeps
MISSING: pkgdep-22_1
Transaction aborted due to unresolved dependencies.
[DEBUG] xbps_pkgdb_unlock: pkgdb_fd 3
[DEBUG] [pkgdb] released ok.
libxbps/shell/update_hold_test:update_pkg_with_held_dep  ->  expected_failure: this test case makes no sense: 19 != 0 (19 != 0)
kyua: E: No previous results file found for test suite result.db.

And here is the output prior to breaking the test:

[DEBUG] XBPS: 0.60 API: 20200423 GIT: 46758bf7
[DEBUG] Processing configuration directory: /tmp/kyua.U9waip/2/work/some_repo/root/empty.conf
[DEBUG] Processing system configuration directory: /tmp/kyua.U9waip/2/work/some_repo/root/usr/local/share/xbps.d
[DEBUG] rootdir=/tmp/kyua.U9waip/2/work/some_repo/root
[DEBUG] metadir=/tmp/kyua.U9waip/2/work/some_repo/root/var/db/xbps
[DEBUG] cachedir=/tmp/kyua.U9waip/2/work/some_repo/root/var/cache/xbps
[DEBUG] confdir=/tmp/kyua.U9waip/2/work/some_repo/root/empty.conf
[DEBUG] sysconfdir=/tmp/kyua.U9waip/2/work/some_repo/root/usr/local/share/xbps.d
[DEBUG] syslog=true
[DEBUG] bestmatching=false
[DEBUG] keepconf=false
[DEBUG] Architecture: x86_64
[DEBUG] Target Architecture: (null)
[DEBUG] Repository[0]=/tmp/kyua.U9waip/2/work/some_repo
[DEBUG] [pkgdb] added vpkg pkgdep-21_1 for pkgheld
[DEBUG] [pkgdb] initialized ok.
[DEBUG] [rpool] checking `/tmp/kyua.U9waip/2/work/some_repo' at index 0
[DEBUG] [repo] `/tmp/kyua.U9waip/2/work/some_repo/x86_64-stagedata' open stagedata No such file or directory
[DEBUG] [rpool] `/tmp/kyua.U9waip/2/work/some_repo' registered.
[DEBUG] xbps_repo_get_pkg: found pkginst-1.0_1
[DEBUG] [trans] `pkginst-1.0_1' stored (/tmp/kyua.U9waip/2/work/some_repo)
[DEBUG] xbps_transaction_install_pkg: trans_find_pkg pkginst: 0
[DEBUG] xbps_transaction_prepare: processing deps
[DEBUG] Finding required dependencies for 'pkginst-1.0_1':
[DEBUG] pkginst-1.0_1: requires dependency 'pkgdep-22_1': [DEBUG] vpkg_user_conf: vpkg_conf pkgdep-21_1 pkg pkgheld vpkgname pkgdep
[DEBUG] vpkg_user_conf: vpkg_conf pkgdep-21_1 pkg pkgheld vpkgname pkgdep
not installed `pkgheld-1.17.4_2 (vpkg)' on hold state! ignoring package.
[DEBUG] pkginst-1.0_1 on hold state! ignoring package.
[DEBUG] xbps_transaction_prepare: checking on hold pkgs
[DEBUG] xbps_transaction_prepare: checking replaces
[DEBUG] xbps_transaction_prepare: checking revdeps
[DEBUG] xbps_transaction_prepare: checking conflicts
[DEBUG] xbps_transaction_prepare: checking shlibs
[DEBUG] xbps_transaction_prepare: computing stats
[DEBUG] [trans] verifying 1 packages.
[DEBUG] pkginst-1.0_1: state 1 rv 0
[DEBUG] xbps_pkgdb_unlock: pkgdb_fd 3
[DEBUG] [pkgdb] released ok.
libxbps/shell/update_hold_test:update_pkg_with_held_dep  ->  passed
kyua: E: No previous results file found for test suite result.db.

Whats wrong with this to me is that it tests installing pkginst and with a missing dep.
Maybe the expected result was to install pkgdep-22_1 instead of using the virtual package provider and the test did not check if correctly if this happens and was broken at some point but did not error out.

[Chocimier]

feels more like a workaround

Why? It looks ok.

Maybe the expected result was to install pkgdep-22_1

0.52 that fixes issue (crash) for which test was written don't install it. The test can be just changed to assert actual result (19) and doubled with below.

	...
	xbps-install -r root -C empty.conf --repository=$PWD -d -yv pkginst pkgdep
	atf_check_equal $? 0

	atf_check_equal $(xbps-query -r root -p pkgver pkgdep) pkgdep-22_1