Skip to content

📦 new: add yes/no as select input#12

Merged
warengonzaga merged 7 commits intowarengonzaga:devfrom
spc-28:feat/yes-no-with-arrow-keys
Oct 6, 2024
Merged

📦 new: add yes/no as select input#12
warengonzaga merged 7 commits intowarengonzaga:devfrom
spc-28:feat/yes-no-with-arrow-keys

Conversation

@spc-28
Copy link
Copy Markdown
Contributor

@spc-28 spc-28 commented Oct 4, 2024 •
edited
Loading

Update: Changed the manual typing of Y and N for commit approval with menu consisting yes and no.
Fixes: #9

@spc-28
Copy link
Copy Markdown
Contributor Author

spc-28 commented Oct 4, 2024

@warengonzaga please let me know if any more changes to be made.

warengonzaga
warengonzaga requested changes Oct 5, 2024
View reviewed changes
Copy link
Copy Markdown
Owner

@warengonzaga warengonzaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's all. I left some comments and suggested changes. @spc-28

@warengonzaga warengonzaga changed the title Feat/yes no with arrow keys 📦 new: add yes/no as select input Oct 5, 2024
@warengonzaga warengonzaga added feature Feature Request (Issue) hacktoberfest-accepted Hacktoberfest (PR) tweak Enhancements (Issue/PR) labels Oct 5, 2024
@warengonzaga warengonzaga linked an issue Oct 5, 2024 that may be closed by this pull request
add better selection when asking for commit suggestion #9
Closed
@spc-28
Copy link
Copy Markdown
Contributor Author

spc-28 commented Oct 5, 2024

@warengonzaga Done with the changes.

Let me know if there is anything for me.

@warengonzaga warengonzaga self-requested a review October 6, 2024 06:14
@spc-28
Copy link
Copy Markdown
Contributor Author

spc-28 commented Oct 6, 2024

@warengonzaga Changed the Placement of Yes/no.

warengonzaga
warengonzaga approved these changes Oct 6, 2024
View reviewed changes
Copy link
Copy Markdown
Owner

@warengonzaga warengonzaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @spc-28 I tested it, and it works. However, there's an issue displaying the logo of the app. I think I can fix it later on. If you can fix it that would be helpful. For now, happy to merge it.

@warengonzaga warengonzaga merged commit 4921212 into warengonzaga:dev Oct 6, 2024
@spc-28
Copy link
Copy Markdown
Contributor Author

spc-28 commented Oct 6, 2024

LGTM @spc-28 I tested it, and it works. However, there's an issue displaying the logo of the app. I think I can fix it later on. If you can fix it that would be helpful. For now, happy to merge it.

Ok i will also look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warengonzaga warengonzaga warengonzaga approved these changes

Assignees

@spc-28 spc-28

Labels

feature Feature Request (Issue) hacktoberfest-accepted Hacktoberfest (PR) tweak Enhancements (Issue/PR)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add better selection when asking for commit suggestion

2 participants

@spc-28 @warengonzaga