📦 new: add context to git commit message#14
Conversation
|
@warengonzaga can u please check if its correct. |
warengonzaga
left a comment
warengonzaga
left a comment
There was a problem hiding this comment.
Please check my requested changes. Looks like it needs a complete git message convention. Not sure what to use in (context) or (scope) I think for now let's use file name of staged file. I leave a reference file where you can edit it.
|
The git commit convention here is my personal convention when building open source projects. I think I have to make a complete specs of my preference. |
warengonzaga
left a comment
warengonzaga
left a comment
There was a problem hiding this comment.
Hey there, thanks for the contribution. Could you take a look at my requested changes?
|
Kindly fix the conflicting file issue @Abhinav-Bansal751. The best way to do this is to merge the changes from the |
warengonzaga
added
hacktoberfest-accepted
warengonzaga
changed the title
warengonzaga
left a comment
warengonzaga
left a comment
There was a problem hiding this comment.
Kindly check the comments and click "resolve conversation" if you already updated the code. It should show "outdated" if you made changes. Lastly, I think the best way is to delete the yarn.lock file I can handle the rest.
|
I fixed the conflict @Abhinav-Bansal751 kindly resolve the requested changes thank you! |
|
Sir,Should i make another commit ?i have deleted "magicc": "^0.2.1", from package.json, made config.json same as earlier. |
|
Yes @Abhinav-Bansal751 please made the requested changes. |
warengonzaga
left a comment
warengonzaga
left a comment
There was a problem hiding this comment.
I have another requested changes @Abhinav-Bansal751 kindly take a look.
warengonzaga
left a comment
warengonzaga
left a comment
There was a problem hiding this comment.
All good @Abhinav-Bansal751 however, I have some requested changes.
warengonzaga
left a comment
warengonzaga
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution!
2 participants
Pull Request
Summary
This PR updates the
config.jsonfile to improve the commit message generation logic. The changes include the addition of a new prompt format for better categorization and context in commit messages.Changes Made
emojiprompt to include a structured format:<emoji> category (context): title..Related Issues