Improve message for config shuffle-salts result

[ernilambar]

Bug Report

• [✓] Yes, I reviewed the contribution guidelines.
• [✓] Yes, more specifically, I reviewed the guidelines on how to write clear bug reports.

Describe the current, buggy behavior

We could improve message of wp config shuffle-salts command when key does not exist.

wp config shuffle-salts WP_CACHE_KEY_SALT

Warning: Could not shuffle the unknown key 'WP_CACHE_KEY_SALT'.
Success: Shuffled the salt keys.

[danielbachhuber]

We could improve message of wp config shuffle-salts command when key does not exist.

@ernilambar To clarify, what would be your suggested improvement?

[ernilambar]

May be we can utilize report_batch_operation_results():

wp config shuffle-salts WP_CACHE_KEY_SALT

Warning: Could not shuffle the unknown key 'WP_CACHE_KEY_SALT'.
Error: No configs shuffled.

OR

Warning: Could not shuffle the unknown key 'WP_CACHE_KEY_SALT'.
Success: Shuffled 0 of 1 configs (1 skipped).

wp config shuffle-salts WP_CACHE_KEY_SALT NONCE_SALT

Warning: Could not shuffle the unknown key 'WP_CACHE_KEY_SALT'.
Error: Only shuffled 1 of 2 configs.

OR

Warning: Could not shuffle the unknown key 'WP_CACHE_KEY_SALT'.
Success: Shuffled 1 of 2 configs (1 skipped).

[danielbachhuber]

@ernilambar I'm amenable to using report_batch_operation_results().

I would call them "salts" instead of "configs", though.

[ernilambar]

@danielbachhuber Should it be Error: Only shuffled 1 of 2 salts. or Success: Shuffled 1 of 2 salts (1 skipped).?

[danielbachhuber]

@ernilambar The latter, I think

[ernilambar]

@danielbachhuber I have noticed contributor-day tag in several issues. Does that mean issues should be kept for Contributor Day to be fixed?

[danielbachhuber]

@ernilambar No, only that it's a good issue for contributor day if it's still open at that time.