storage: optimize sqlite insert with upsert syntax #261999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpasero
reviewed
Aug 17, 2025
bpasero
approved these changes
Aug 18, 2025
Member
bpasero
left a comment
bpasero
left a comment
There was a problem hiding this comment.
Actually, lets keep the CREATE statement as it was, my perf testing does not show any improvements changing that and I feel we should not have a mix of old and new schema here. Besides, the CREATE statement as it was seems better to explain the intent.
I also played around with setting the key to PRIMARY KEY but that does not seem to yield significant improvements.
Thanks for reporting and fixing this. This kind of contribution requires some good understanding of our code 👏
lszomoru
approved these changes
Aug 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #260807
cc @bpasero