Skip to content

Update SolidStart template to modify Vite config#12728

Merged
jamesopstad merged 4 commits intomainfrom
james/fix-c3-solid-start
Mar 2, 2026
Merged

Update SolidStart template to modify Vite config#12728
jamesopstad merged 4 commits intomainfrom
james/fix-c3-solid-start

Conversation

@jamesopstad
Copy link
Contributor

@jamesopstad jamesopstad commented Mar 2, 2026

Update SolidStart template for compatibility with v2.

SolidStart v2 uses the nitro Vite plugin so we now update the Nitro config in vite.config.ts rather than app.config.ts.

Note that Nitro automatically populates the main and assets fields in the output Wrangler config file.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: covered by existing tests
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal change

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2026

🦋 Changeset detected

Latest commit: 6f86956

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 2, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12728

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12728

miniflare

npm i https://pkg.pr.new/miniflare@12728

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12728

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12728

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12728

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12728

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12728

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12728

wrangler

npm i https://pkg.pr.new/wrangler@12728

commit: a0f8622

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

✅ All changesets look good

@jamesopstad jamesopstad marked this pull request as ready for review March 2, 2026 10:38
@jamesopstad jamesopstad requested a review from a team as a code owner March 2, 2026 10:38
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 2, 2026
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 6 additional findings in Devin Review.

Open in Devin Review

@jamesopstad jamesopstad merged commit bbe09b6 into main Mar 2, 2026
34 checks passed
@jamesopstad jamesopstad deleted the james/fix-c3-solid-start branch March 2, 2026 11:27
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants