Port server cache fix to release#9932
Port server cache fix to release#9932IanMatthewHuff merged 2 commits intomicrosoft:release-2020.02from
Conversation
…crosoft#9929) * don't cancel an already resolve servercache just due to disableUI changes * don't pull data a second time
IanMatthewHuff
requested review from
DavidKutu,
DonJayamanne,
karthiknadig and
rchiodo
news/2 Fixes/9926.md
Outdated
| @@ -0,0 +1 @@ | |||
| Use the autoStart server when available. | |||
There was a problem hiding this comment.
@rchiodo . Did we change the process? I didn't do this on previous release ports, thought that it was generated by running 'news' task as part of the final release plan.
There was a problem hiding this comment.
I think other people have started running the task during their port? @karthiknadig should we update the changelog when porting fixes?
There was a problem hiding this comment.
It looks like that's what David did here:
https://github.com/microsoft/vscode-python/pull/9912/files
There was a problem hiding this comment.
Hmm, guess I can do that. Seems like that would mess up the cherry-pick since that has the news file in it. But I could just delete that as well.
There was a problem hiding this comment.
Via Karthik it sounds like we can do either. But I was already updating the CL, so I just went ahead with it.
Codecov Report
@@ Coverage Diff @@
## release-2020.02 #9932 +/- ##
===================================================
- Coverage 61.21% 61.01% -0.21%
===================================================
Files 564 564
Lines 30061 30412 +351
Branches 4545 4635 +90
===================================================
+ Hits 18403 18555 +152
- Misses 10629 10817 +188
- Partials 1029 1040 +11
Continue to review full report at Codecov.
|
|
Stuck CI :( |
|
Kudos, SonarCloud Quality Gate passed!
|
4 participants
For #9926
Porting this PR into release:
#9929
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).