tools: dump config.gypi as json#60794
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Nov 22, 2025
Merged
Conversation
This helps js2c processing the node.gypi correctly when a string contains a quote.
nodejs-github-bot
added
build
richardlau
approved these changes
Nov 20, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60794 +/- ##
==========================================
+ Coverage 88.04% 88.55% +0.51%
==========================================
Files 703 703
Lines 208260 208249 -11
Branches 40068 40153 +85
==========================================
+ Hits 183360 184417 +1057
+ Misses 16840 15838 -1002
+ Partials 8060 7994 -66 🚀 New features to boost your workflow:
|
github-actions
bot
removed
the
request-ci
Collaborator
marco-ippolito
approved these changes
Nov 21, 2025
cjihrig
approved these changes
Nov 21, 2025
Collaborator
Collaborator
aduh95
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 7fd3688 |
targos
pushed a commit
that referenced
this pull request
Nov 27, 2025
This helps js2c processing the node.gypi correctly when a string contains a quote. PR-URL: #60794 Refs: #60703 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jan 9, 2026
This helps js2c processing the node.gypi correctly when a string contains a quote. PR-URL: #60794 Refs: #60703 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 13, 2026
This helps js2c processing the node.gypi correctly when a string contains a quote. PR-URL: #60794 Refs: #60703 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jan 19, 2026
This helps js2c processing the node.gypi correctly when a string contains a quote. PR-URL: #60794 Refs: #60703 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 11, 2026
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 11, 2026
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 11, 2026
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 12, 2026
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 12, 2026
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 13, 2026
* chore: bump node in DEPS to v24.13.1 * chore: fixup patches refs: * nodejs/node#60425 * nodejs/node#61270 * nodejs/node#61044 * fix: generate_config_gypi needs to generate valid JSON nodejs/node#60794 * doc: align Buffer.concat documentation with behavior nodejs/node#60405 * src: fix off-thread cert loading in bundled cert mode nodejs/node#60764 * build: fix extraneous includes --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 13, 2026
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 13, 2026
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 13, 2026
* chore: bump node in DEPS to v24.13.1 * chore: fixup patches refs: * nodejs/node#60425 * nodejs/node#61270 * nodejs/node#61044 * fix: generate_config_gypi needs to generate valid JSON nodejs/node#60794 * doc: align Buffer.concat documentation with behavior nodejs/node#60405 * src: fix off-thread cert loading in bundled cert mode nodejs/node#60764 * chore: fixup patch indices * build: fix extraneous includes --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 13, 2026
* chore: bump node in DEPS to v24.13.1 * chore: fixup patches refs: * nodejs/node#60425 * nodejs/node#61270 * nodejs/node#61044 * fix: generate_config_gypi needs to generate valid JSON nodejs/node#60794 * doc: align Buffer.concat documentation with behavior nodejs/node#60405 * src: fix off-thread cert loading in bundled cert mode nodejs/node#60764 * chore: fixup patch indices * build: fix extraneous includes --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Feb 17, 2026
This helps js2c processing the node.gypi correctly when a string contains a quote. PR-URL: #60794 Refs: #60703 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Feb 19, 2026
This helps js2c processing the node.gypi correctly when a string contains a quote. PR-URL: #60794 Refs: #60703 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Feb 21, 2026
This helps js2c processing the node.gypi correctly when a string contains a quote. PR-URL: #60794 Refs: #60703 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
aduh95
pushed a commit
that referenced
this pull request
Feb 23, 2026
This helps js2c processing the node.gypi correctly when a string contains a quote. PR-URL: #60794 Refs: #60703 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
kycutler
pushed a commit
to kycutler/electron
that referenced
this pull request
Feb 26, 2026
* chore: bump node in DEPS to v24.13.1 * chore: fixup patches refs: * nodejs/node#60425 * nodejs/node#61270 * nodejs/node#61044 * fix: generate_config_gypi needs to generate valid JSON nodejs/node#60794 * doc: align Buffer.concat documentation with behavior nodejs/node#60405 * src: fix off-thread cert loading in bundled cert mode nodejs/node#60764 * build: fix extraneous includes --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]>
jkleinsc
added a commit
to electron/electron
that referenced
this pull request
Mar 9, 2026
https: //github.com/nodejs/node/pull/60794 (cherry picked from commit a1d06cd) Co-Authored-By: Shelley Vohr <[email protected]>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Mar 10, 2026
* chore: bump node in DEPS to v22.22.1 * chore: update patches * chore: fixup remove_obsolete_noarraybufferzerofillscope.patch * deps: update simdjson to 4.2.4 nodejs/node#61056 * fix: generate_config_gypi needs to generate valid JSON https: //github.com/nodejs/node/pull/60794 (cherry picked from commit a1d06cd) Co-Authored-By: Shelley Vohr <[email protected]> * src: fix off-thread cert loading in bundled cert mode nodejs/node#60764 (cherry picked from commit cb4deec) This test fails on boringssl incompatibilities: https://github.com/electron/electron/pull/49744/changes#r2799802487 Co-Authored-By: Shelley Vohr <[email protected]> * test: move sea tests into test/sea nodejs/node#60250 (cherry picked from commit 695929b) * src: fix off-thread cert loading in bundled cert mode nodejs/node#60764 The Node.js cli flag --use-bundled-ca is not supported in Electron --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <[email protected]> Co-authored-by: Shelley Vohr <[email protected]> Co-authored-by: John Kleinschmidt <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps js2c processing the node.gypi correctly when a string contains a quote.
Refs: #60703