Repository navigation
Flush Android text editors before separate press actions - #147
Merged
simonhamp merged 1 commit intoOct 24, 2026
Merged
Conversation
Exercise the production editors and Button across sync modes and callback updates. Requires the companion Mobile focused-input flush registration seam. Amp-Thread-ID: https://ampcode.com/threads/T-01a15d54-08af-74af-a9fe-b7cfe5fd268c Co-authored-by: Wojt Janowski <wojt@clinically.com.au>
Member
|
thanks |
ricardovfreixo
added a commit
to ricardovfreixo/mobile-ui
that referenced
this pull request
Oct 25, 2026
Bounded merge for the companion PR NativePHP#162: takes upstream's bounded gesture areas (NativePHP#173), the text/font/keyboard/divider/sheet fixes (NativePHP#142, NativePHP#155, NativePHP#156, NativePHP#163, NativePHP#147, NativePHP#168, NativePHP#170) and the tab-row chrome fix (NativePHP#167), while keeping this branch's scroll-target seam intact — the live pager page availability guard (PagerPageContext), the ancestor pager chain in isAvailable(), and the Android list scroll-target registration. TabRowRenderer.kt resolves to upstream's version: both sides had independently removed the unsupported LocalTopBarColor / LocalTopTabRow hooks, so nothing was reintroduced and no stubs added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rememberUpdatedStateso the focused closure always uses current dispatcher/reporter callback props. Blur and pre-action flushing share existing deduplication and debounce cancellation.Important
Do not merge until NativePHP Mobile ships a release containing NativePHP/mobile-air#565.
This relies on the companion Android
fieldFocused(..., flush)change from NativePHP/mobile-air#565 (merged tomainon 22 Oct 2026, not yet released; latest release is 4.6.0). Against unchanged Mobile 4.6.0 the pre-press flush won't work.Before merging: bump
nativephp/mobileincomposer.jsonto the first release that includes #565.Test plan
tests/androidmodule: 12 tests passed, no failures/skips, using JDK 21 / SDK 36 with-PmobileRoot=/absolute/path/to/patched/mobile(command documented in its README).git diff --checkand local CodeRabbit review: passed, zero findings across all changed text files.