Skip to content

Support rules_jvm_external or j2cl_maven_import_external private registry  #212

Open
Open
Support rules_jvm_external or j2cl_maven_import_external private registry #212

Description

@tamascsaba
tamascsaba
opened on Sep 4, 2023

Hi 👋
I would like to use j2cl with private maven registry. I checked j2cl_maven_import_external function, but it is only support public repository download:

j2cl/build_defs/internal_do_not_use/j2cl_repo.bzl

Line 36 in 54deeb5

repository_ctx.download(

It would be great add credential support to download method: https://github.com/bazelbuild/bazel/blob/290fc80a5aae9dea06de52deed7098a5b8443f26/src/main/java/com/google/devtools/build/lib/bazel/repository/downloader/HttpDownloader.java#L77

Maybe an other solution when it would be possible integrate with rules_jvm_external rule, which support private registries.
https://github.com/bazelbuild/rules_jvm_external#features

Thank you very much for the response.

Activity

  1. gkdn commented on Sep 6, 2023

    @gkdn
    gkdn
    on Sep 6, 2023
    Member

    It would be good idea to just wrap around rules_jvm_external.

    My comment here:

    j2cl/build_defs/internal_do_not_use/j2cl_repo.bzl

    Line 9 in 54deeb5

    # TODO(b/71517767): This could a simple wrapper around java_import_external if
    might not be accurate. We do support source jars with j2cl_library so it might be possible today. Also it could be that I meant something else there, who knows :) Anyway would you like to give it a shot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions