Skip to content

Kitchen sink changes - #334932

Merged
Dirk Bäumer (dbaeumer) merged 21 commits into
microsoft:mainfrom
aguashui:fix-typos-and-grammar
Oct 21, 2026
Merged

Dirk Bäumer (dbaeumer) merged 21 commits into
microsoft:mainfrom
aguashui:fix-typos-and-grammar

Conversation

@aguashui

@aguashui Noah Webber (aguashui) commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

Fixes verified typos and grammatical errors across documentation, instructions, comments, source files, and test files.

Copilot AI balanced review requested due to automatic review settings September 7, 2026 15:02
@aguashui Noah Webber (aguashui) changed the title Fix typos and grammatical errors across docs, source, and tests Kitchen sink changes Sep 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Several edited lines remain grammatically incorrect, including a user-facing CLI error message.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Corrects spelling and grammar across source comments, tests, documentation, build tooling, and CLI messages without intended behavioral changes.

Changes:

  • Fixes misspelled comments, test names, and documentation.
  • Renames misspelled test-local variables and references.
  • Corrects CLI and logging messages.
File summaries
File Description
src/vs/workbench/test/browser/parts/statusbar/statusbarModel.test.ts Corrects test name.
src/vs/workbench/test/browser/parts/editor/editorCommandsContext.test.ts Corrects test name.
src/vs/workbench/services/workingCopy/common/storedFileWorkingCopy.ts Corrects save-flow comment.
src/vs/workbench/services/textfile/common/textFileEditorModel.ts Corrects save-flow comment.
src/vs/workbench/services/extensions/test/common/rpcProtocol.test.ts Corrects test name.
src/vs/workbench/services/extensionManagement/test/browser/extensionEnablementService.test.ts Corrects test name.
src/vs/workbench/contrib/snippets/browser/snippetCompletionProvider.ts Corrects snippet comment.
src/vs/workbench/contrib/comments/common/commentModel.ts Corrects caching comment.
src/vs/platform/remote/node/wsl.ts Corrects WSL documentation.
src/vs/platform/native/electron-main/nativeHostMainService.ts Corrects log message.
src/vs/platform/markers/test/common/markerService.test.ts Corrects test name.
src/vs/platform/keybinding/common/keybindingResolver.ts Corrects API documentation.
src/vs/platform/instantiation/common/instantiationService.ts Corrects service comment.
src/vs/platform/configuration/test/common/policyConfiguration.test.ts Renames misspelled test locals.
src/vs/platform/configuration/test/common/configurationService.test.ts Corrects test comments.
src/vs/editor/contrib/contextmenu/browser/contextmenu.ts Corrects context-menu comment.
src/vs/code/electron-utility/sharedProcess/contrib/codeCacheCleaner.ts Corrects cache comment.
src/vs/code/electron-main/app.ts Updates window and protocol comments.
src/vs/base/test/common/types.test.ts Corrects test message.
src/vs/base/test/common/labels.test.ts Corrects test comment.
src/vs/base/test/common/glob.test.ts Corrects test name.
src/vs/base/test/common/event.test.ts Corrects event-test comments.
src/vs/base/test/common/arrays.test.ts Renames misspelled test parameter.
src/vs/base/test/browser/comparers.test.ts Corrects test comment.
src/vs/base/common/jsonSchema.ts Corrects serialization comment.
src/vs/base/common/color.ts Corrects API documentation.
src/vs/base/common/async.ts Corrects idle-callback documentation.
extensions/theme-seti/build/update-icon-theme.js Corrects build-script comments.
extensions/copilot/.agents/skills/github-copilot-upgrader/SKILL.md Corrects upgrader instructions.
cli/src/util/os.rs Corrects Windows comment.
cli/src/util/errors.rs Corrects CLI error message.
cli/src/tunnels/protocol.rs Corrects protocol method documentation.
cli/src/tunnels/dev_tunnels.rs Corrects tunnel text and documentation.
cli/src/rpc.rs Corrects serialization documentation.
build/lib/tsb/builder.ts Corrects builder comment.
build/lib/mangle/index.ts Corrects mangler comments.
.github/instructions/observables.instructions.md Corrects observable instructions.
.github/instructions/committing.instructions.md Corrects committing instructions.
.eslint-plugin-local/README.md Updates custom-rule documentation.
Review details

Suppressed comments (1)

extensions/copilot/.agents/skills/github-copilot-upgrader/SKILL.md:25

  • This instruction still has an unnecessary comma before “until” and treats the activities as inconsistently capitalized labels. Describing them as a cycle is grammatical and clearer.
9. Repeat Compile, Fix, Test, until all tests are passing
  • Files reviewed: 39/39 changed files
  • Comments generated: 5
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .eslint-plugin-local/README.md Resolved
Comment thread cli/src/util/errors.rs Resolved
Comment thread src/vs/base/test/common/event.test.ts Resolved
Comment thread src/vs/code/electron-main/app.ts Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are consistent spelling and grammar corrections with no unintended logic changes.

Review details
  • Files reviewed: 39/39 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@wenma531

noreply (wenma531) commented Sep 7, 2026 via email

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are nonfunctional proofreading updates, with only a minor documentation capitalization issue noted.

Review details

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

.eslint-plugin-local/README.md:123

  • API is an acronym and should remain uppercase in this edited sentence; the sentence should also end with a period.
  • Files reviewed: 41/41 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@aguashui

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@aguashui
Noah Webber (aguashui) marked this pull request as ready for review September 7, 2026 15:42
@vs-code-engineering

Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

Robo (@deepak1556)

Matched files:

  • src/vs/code/electron-main/app.ts
  • src/vs/code/electron-utility/sharedProcess/contrib/codeCacheCleaner.ts

@dbaeumer

Copy link
Copy Markdown
Member

Noah Webber (@aguashui) you can't make changes to our engineering system. Please see https://github.com/microsoft/vscode/pull/334932/checks?check_run_id=105309008877

Can you leave the two files out.

@dbaeumer Dirk Bäumer (dbaeumer) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See latest comment

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The corrections are internally consistent, and all renamed identifiers and references remain aligned.

0 open findings

🧠 Review effort: Balanced

roblourens
roblourens previously approved these changes Oct 16, 2026
@dbaeumer

Copy link
Copy Markdown
Member

Noah Webber (@aguashui) could you please resolve the merge conflicts. Thanks!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are limited to wording corrections and consistent identifier renames, with no identified regressions.

No open issues 🎉

Review effort: Balanced

@dbaeumer
Dirk Bäumer (dbaeumer) merged commit 2deba53 into microsoft:main Oct 21, 2026
58 checks passed
@vs-code-engineering vs-code-engineering Bot added this to the 1.144.0 milestone Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants