performance.timerify(fn, options) always return the same timerifed function

Version

master branch

Platform

All

Subsystem

perf_hooks

What steps will reproduce the bug?

function f() {}
let h1 = perf_hooks.createHistogram()
let h2 = perf_hooks.createHistogram()
let f1 = perf_hooks.performance.timerify(f, {histogram: h1})
let f2 = perf_hooks.performance.timerify(f, {histogram: h2})
f1 !== f2 // expect true, actual false

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior?

Every calls of performance.timerify(fn) should return a new timerified function instance for fn, at least if options is provided.

What do you see instead?

Currently timerify will cache the timerfied function as fn[kTimerified], so timerify(fn) always return same timerified function for fn, even different options was given.

Additional information

Current cache behavior is not very useful, and cause problems for the use cases which need multiple timerified versions (for example, record timing for different usage of the same function).

PS. It also will throw if fn is frozen/sealed/non-extensible.

Lines 74 to 123 in a75d4e2

    
           if (fn[kTimerified]) return fn[kTimerified]; 
        
           const constructor = isConstructor(fn); 
        
           function timerified(...args) { 
        
             const start = now(); 
        
             const result = constructor ? 
        
               ReflectConstruct(fn, args, fn) : 
        
               ReflectApply(fn, this, args); 
        
             if (!constructor && typeof result?.finally === 'function') { 
        
               return result.finally( 
        
                 FunctionPrototypeBind( 
        
                   processComplete, 
        
                   result, 
        
                   fn.name, 
        
                   start, 
        
                   args, 
        
                   histogram)); 
        
             } 
        
             processComplete(fn.name, start, args, histogram); 
        
             return result; 
        
           } 
        
           ObjectDefineProperties(timerified, { 
        
             [kTimerified]: { 
        
               configurable: false, 
        
               enumerable: false, 
        
               value: timerified, 
        
             }, 
        
             length: { 
        
               configurable: false, 
        
               enumerable: true, 
        
               value: fn.length, 
        
             }, 
        
             name: { 
        
               configurable: false, 
        
               enumerable: true, 
        
               value: `timerified ${fn.name}` 
        
             } 
        
           }); 
        
           ObjectDefineProperties(fn, { 
        
             [kTimerified]: { 
        
               configurable: false, 
        
               enumerable: false, 
        
               value: timerified, 
        
             } 
        
           }); 
        
           return timerified;

Upstream PR: #37136

It seems like the memorization is for the performance

I'm working on this issue

perf_hooks: return different functions in timerify

Navigation Menu

performance.timerify(fn, options) always return the same timerifed function #42742

Version

Platform

Subsystem

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior?

What do you see instead?

Additional information

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (fn[kTimerified]) return fn[kTimerified];

	const constructor = isConstructor(fn);

	function timerified(...args) {
	const start = now();
	const result = constructor ?
	ReflectConstruct(fn, args, fn) :
	ReflectApply(fn, this, args);
	if (!constructor && typeof result?.finally === 'function') {
	return result.finally(
	FunctionPrototypeBind(
	processComplete,
	result,
	fn.name,
	start,
	args,
	histogram));
	}
	processComplete(fn.name, start, args, histogram);
	return result;
	}

	ObjectDefineProperties(timerified, {
	[kTimerified]: {
	configurable: false,
	enumerable: false,
	value: timerified,
	},
	length: {
	configurable: false,
	enumerable: true,
	value: fn.length,
	},
	name: {
	configurable: false,
	enumerable: true,
	value: `timerified ${fn.name}`
	}
	});

	ObjectDefineProperties(fn, {
	[kTimerified]: {
	configurable: false,
	enumerable: false,
	value: timerified,
	}
	});

	return timerified;

performance.timerify(fn, options) always return the same timerifed function #42742

Description

Version

Platform

Subsystem

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior?

What do you see instead?

Additional information

Activity

himself65 commented on Apr 24, 2022

himself65 commented on Apr 24, 2022

himself65 commented on Apr 24, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions