Github logo not visible in the login page #1023

New issue

mehrad · 2023-05-14T11:37:21+02:00

mehrad commented

2023-05-14 11:37:21 +02:00

I just realized that the new nice dark theme of Codeberg has cause the Github logo to be practically invisible. In the screenshot below, I am comparing the current Codeberg vs. the Gitea demo:

I suggest #1d394a for the div to follow the blue style of Codeberg, and also improve visibility

I just realized that the new nice dark theme of Codeberg has cause the Github logo to be practically invisible. In the screenshot below, I am comparing the current Codeberg vs. the Gitea demo: ![image](/attachments/5e48eded-0e62-4953-83b1-f12a6fe74f39) ------- I suggest `#1d394a` for the div to follow the blue style of Codeberg, and also improve visibility ![image](/attachments/f348b601-c667-4e1e-9e9c-25d7fbf98394)

image.png

100 KiB

image.png

100 KiB

silverwind commented

2023-05-15 21:55:33 +02:00

Will be fixed with https://github.com/go-gitea/gitea/pull/24740

n0toose commented

2023-05-15 22:00:29 +02:00

AWESOME JOB!!!!!!! Thank you for your efforts! @silverwind

n0toose commented

2023-05-15 22:01:45 +02:00

Is a duplicate of #917, deliberately not closing as this is where the discussion / updates seem to be happening and is cross-linked from the Gitea PR.

Is a duplicate of https://codeberg.org/Codeberg/Community/issues/917, deliberately not closing as this is where the discussion / updates seem to be happening and is cross-linked from the Gitea PR.

n0toose added the

duplicate

s/Forgejo

upstream

labels

2023-05-15 22:01:53 +02:00

n0toose referenced this issue

2023-05-15 22:05:03 +02:00

Use better GitHub icon on sign in page dark mode #917

crystal commented

2023-05-16 05:00:28 +02:00

I am not in favor of keeping duplicate issues open in spite of the discussion that has taken place here, it'll just increase the odds that one of them gets missed when the fix is downstreamed and will sit cluttering the issue tracker.

earl-warren referenced this issue from a commit

2023-05-16 07:32:57 +02:00

Rework Oauth login buttons, swap github logo to monocolor (#24740)

n0toose commented

2023-05-16 10:39:19 +02:00

This case was treated as an exception (possibly wouldn't have happened if duplicate issue was closed fast enough, but on the other hand, this may not have been resolved if the Gitea maintainer here had missed the other issue) and I tried to communicate that well enough so as to not bother an external participant in the conversation for the first time, was hoping that a big deal wouldn't be made out of it as I hoped that my intentions would've been obvious enough so as to not have to justify them.

I had no plans to do this again in the future.

PR merged in https://github.com/go-gitea/gitea/pull/24740, keeping both issues open until it lands in Codeberg.

This case was treated as an exception (possibly wouldn't have happened if duplicate issue was closed fast enough, but on the other hand, this may not have been resolved if the Gitea maintainer here had missed the other issue) and I tried to communicate that well enough so as to not bother an external participant in the conversation for the first time, was hoping that a big deal wouldn't be made out of it as I hoped that my intentions would've been obvious enough so as to not have to justify them. I had no plans to do this again in the future. PR merged in https://github.com/go-gitea/gitea/pull/24740, keeping both issues open until it lands in Codeberg.

mehrad commented

2023-05-18 16:22:15 +02:00

Thanks for point out that this is potentially a duplicate. As far as I can tell, this is not a duplicate although both point at the same direction. To clarify my rational, the #917 points at changing the icon and the suggestion is a neon icon for github. This thread is directly aiming at a simple CSS change of the surrounding box.

These said, the #917 did not show up in any of my searches neither in Codeberg issue not gitea, most probably because of bad formatting of the text and title. Perhaps this is why the gitea maintainer also missed that one as well. I myself am a maintainer of some git repos, and I sometimes have to modify the title to make it more specific to the issue at hand and avoid duplicates.

Again, I apologize for potential duplicate, but it practically cannot be avoided if it does not show up as a potential hit in any of the searches.

Thanks for point out that this is potentially a duplicate. As far as I can tell, this is not a duplicate although both point at the same direction. To clarify my rational, the #917 points at changing the icon and the suggestion is a neon icon for github. This thread is directly aiming at a simple CSS change of the surrounding box. These said, the #917 did not show up in any of my searches neither in Codeberg issue not gitea, most probably because of bad formatting of the text and title. Perhaps this is why the gitea maintainer also missed that one as well. I myself am a maintainer of some git repos, and I sometimes have to modify the title to make it more specific to the issue at hand and avoid duplicates. Again, I apologize for potential duplicate, but it practically cannot be avoided if it does not show up as a potential hit in any of the searches.

n0toose commented

2023-08-11 00:39:23 +02:00

Hey @mehrad, I believe that this issue has been fixed with the latest update that was installed today (v1.20). If I'm wrong, please don't hesitate to reopen this issue.

🚀 1

n0toose closed this issue

2023-08-11 00:39:37 +02:00

n0toose referenced this issue

2023-08-11 00:40:09 +02:00

Use better GitHub icon on sign in page dark mode #917

mehrad commented

2023-08-15 17:43:12 +02:00

I agree, the current state looks slick and nice. Thanks.

👍 1

n0toose commented

2023-08-15 18:36:12 +02:00