Use better GitHub icon on sign in page dark mode #917

New issue

HexagonCDN · 2023-01-30T01:34:33+01:00

HexagonCDN commented

2023-01-30 01:34:33 +01:00

That GitHub icon on sign in page looks ugly in dark mode. However, there is this beautiful GitHub icon on New Migration screen.

We should use the same icons from New Migration screen.

I also notice that GitLab icon on sign in page has white ugly border around. GitLab icon on New Migration screen is also much cleaner.

![image](/attachments/c8278acc-14b0-4738-9d39-7129eac74218) That GitHub icon on sign in page looks ugly in dark mode. However, there is this beautiful GitHub icon on New Migration screen. ![image](/attachments/2558a81f-42c8-40c6-96fa-42d2b84096be) We should use the same icons from New Migration screen. I also notice that GitLab icon on sign in page has white ugly border around. GitLab icon on New Migration screen is also much cleaner. ![image](/attachments/d3b513be-06de-4201-a19f-f1e3d31b2b55)

image.png

5.1 KiB

image.png

29 KiB

image.png

12 KiB

👍 3

rdwz added the

s/Forgejo

label

2023-01-30 12:16:49 +01:00

fnetX added the

contributions welcome

label

2023-01-30 18:56:35 +01:00

crystal commented

2023-01-31 06:57:09 +01:00

That's an old GitLab logo too. Perhaps it should be updated

👍 1

n0toose commented

2023-04-21 14:42:16 +02:00

This was just reported to me by a new user IRL and seems to be a bad "first impression" on users that haven't registered yet, as it makes our UX look very amateurish.

I am not sure how to modify this upstream as e.g. /assets/img/auth/github.png is not a file that I can find under https://codeberg.org/go-gitea/gitea, https://codeberg.org/forgejo/forgejo or https://codeberg.org/codeberg/forgejo.

However, the ["New Migration" page] uses some very unique "Gitea-shipped" .svg icons that look, frankly, very, very good: https://codeberg.org/repo/migrate

I looked in the upstream template responsible for displaying the current icons, and couldn't figure out whether I could show those .svg's "by default" instead without resorting to some hardcoded hacks: go-gitea/gitea@68e934ab5d/templates/user/auth/signin_inner.tmpl

This was just reported to me by a new user IRL and seems to be a bad "first impression" on users that haven't registered yet, as it makes our UX look very amateurish. I am not sure how to modify this upstream as e.g. `/assets/img/auth/github.png` is not a file that I can find under https://codeberg.org/go-gitea/gitea, https://codeberg.org/forgejo/forgejo or https://codeberg.org/codeberg/forgejo. However, the ["New Migration" page] uses some very unique "Gitea-shipped" .svg icons that look, frankly, very, very good: https://codeberg.org/repo/migrate I looked in the upstream template responsible for displaying the current icons, and couldn't figure out whether I could show those .svg's "by default" instead without resorting to some hardcoded hacks: https://github.com/go-gitea/gitea/blob/68e934ab5de6a4e8bec6f3faa8bf1e05899b8fb8/templates/user/auth/signin_inner.tmpl

👍 2 ❤️ 1

n0toose commented

2023-04-21 14:42:53 +02:00

I suspect this is Codeberg-specific, feel free to correct me if I'm wrong.

n0toose added the

Codeberg

label

2023-04-21 14:48:02 +02:00

crystal commented

2023-04-21 17:05:41 +02:00

https://codeberg.org/forgejo/forgejo/src/branch/forgejo/public/img/auth/github.png

👍 1

n0toose removed the

Codeberg

label

2023-04-21 17:06:57 +02:00

n0toose referenced this issue

2023-05-15 22:01:45 +02:00

Github logo not visible in the login page #1023

n0toose commented

2023-05-15 22:05:03 +02:00

This issue is being actively worked on - discussion is continuing on #1023 as the very awesome Gitea maintainer that is working on fixing this saw the duplicate issue first and not this one. Both issues will be closed when the PR is merged.

This issue is being actively worked on - discussion is continuing on https://codeberg.org/Codeberg/Community/issues/1023 as the very awesome Gitea maintainer that is working on fixing this saw the duplicate issue first and not this one. Both issues will be closed when the PR is merged.

silverwind commented

2023-05-15 22:46:52 +02:00

That GitHub icon on sign in page looks ugly in dark mode. However, there is this beautiful GitHub icon on New Migration screen.

It might be beautiful, but it's rarely used even by GitHub themselves, so I opted to use the mono-color variant in above PR for both pages.

> That GitHub icon on sign in page looks ugly in dark mode. However, there is this beautiful GitHub icon on New Migration screen. It might be beautiful, but it's rarely used even by GitHub themselves, so I opted to use the mono-color variant in above PR for both pages.

silverwind commented

2023-05-16 00:03:43 +02:00