Block border #139
Merged
Block border #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not seem to be supported.
No longer relevant since it's now possible to set a border on the block.
akirk
approved these changes
Dec 2, 2022
Member
akirk
left a comment
akirk
left a comment
There was a problem hiding this comment.
Tested and it works! I observed how it doesn't give feedback about invalid values but just siltently dismisses it. Ok for a first iteration.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #136
Fixes issue with height handle being cut off
This PR allows for setting a border directly on the block, without needing to resort to adding it inside a Group block, and setting the border there. Some refactoring was done to make it easier to handle attributes and pass them around.
Screen capture
Screen.Recording.2022-12-02.at.14.25.51.mov