Skip to content

fix(#1540): fix default selection in settings #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thecoolwinter merged 2 commits into from
Jan 9, 2024
Merged

fix(#1540): fix default selection in settings #1547

thecoolwinter merged 2 commits into from
Jan 9, 2024

Conversation

@RayZhao1998
Copy link
Collaborator

@RayZhao1998 RayZhao1998 commented Jan 6, 2024 •
edited
Loading

Description

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

截屏2024-01-06 23 13 41
2024-01-06.22.42.01.mov

austincondiff
austincondiff approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@austincondiff austincondiff added the bug Something isn't working label Jan 9, 2024
@thecoolwinter thecoolwinter merged commit 683942e into CodeEditApp:main Jan 9, 2024
@tom-ludwig tom-ludwig mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@austincondiff austincondiff austincondiff approved these changes

@thecoolwinter thecoolwinter thecoolwinter approved these changes

Assignees

@RayZhao1998 RayZhao1998

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RayZhao1998 @austincondiff @thecoolwinter