Skip to content

Added Tooltips for Btns In Navigator Bottom Toolbar #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
austincondiff merged 2 commits into from
Apr 12, 2024
Merged

Added Tooltips for Btns In Navigator Bottom Toolbar #1668

austincondiff merged 2 commits into from
Apr 12, 2024

Conversation

@dvandyy
Copy link
Contributor

@dvandyy dvandyy commented Apr 10, 2024

Description

Added missing tooltips for btns in navigator bottom toolbar
Text is same as Xcode.
Filter is not working yet so this could be fine for now.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Project Navigator
image
image
image

Version control tab
image

Search tab
image

austincondiff
austincondiff previously approved these changes Apr 10, 2024
View reviewed changes
FastestMolasses
FastestMolasses previously approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@FastestMolasses FastestMolasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0xWDG
0xWDG requested changes Apr 11, 2024
View reviewed changes
@0xWDG 0xWDG dismissed stale reviews from FastestMolasses and austincondiff via 28d5e7b April 11, 2024 07:40
0xWDG
0xWDG approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@0xWDG 0xWDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@austincondiff austincondiff merged commit a759891 into CodeEditApp:main Apr 12, 2024
@thecoolwinter thecoolwinter changed the title added tooltips for btns in navigator bottom toolbar Added Tooltips for Btns In Navigator Bottom Toolbar Jul 19, 2024
@thecoolwinter thecoolwinter added the enhancement New feature or request label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FastestMolasses FastestMolasses FastestMolasses left review comments

@0xWDG 0xWDG 0xWDG approved these changes

@tom-ludwig tom-ludwig tom-ludwig approved these changes

@austincondiff austincondiff austincondiff left review comments

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

+1 more reviewer

@deepal15 deepal15 deepal15 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐞 Tooltips on buttons are not working

7 participants

@dvandyy @austincondiff @0xWDG @deepal15 @FastestMolasses @tom-ludwig @thecoolwinter