Skip to content

Using the correct color when File Icon Type is set to Monochrome #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tom-ludwig merged 1 commit into from
Jun 22, 2024
Merged

Using the correct color when File Icon Type is set to Monochrome #1766

tom-ludwig merged 1 commit into from
Jun 22, 2024

Conversation

@austincondiff
Copy link
Collaborator

@austincondiff austincondiff commented Jun 20, 2024 •
edited
Loading

Description

Added CoolGray color and applied to icons when file icon type setting is set to monochrome.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

image image

thecoolwinter
thecoolwinter approved these changes Jun 22, 2024
View reviewed changes
Copy link
Collaborator

@thecoolwinter thecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bombardier200
Copy link
Contributor

bombardier200 commented Jun 22, 2024

Fix swiftlint issues.

@tom-ludwig tom-ludwig merged commit 919f419 into main Jun 22, 2024
@tom-ludwig tom-ludwig deleted the monochrome-icons branch June 22, 2024 14:40
@thecoolwinter thecoolwinter added the bug Something isn't working label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bombardier200 bombardier200 bombardier200 approved these changes

@thecoolwinter thecoolwinter thecoolwinter approved these changes

@tom-ludwig tom-ludwig tom-ludwig approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@austincondiff @bombardier200 @thecoolwinter @tom-ludwig