Skip to content

Clean Up Child Processes #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thecoolwinter merged 16 commits into from
Sep 25, 2024
Merged

Clean Up Child Processes #1885

thecoolwinter merged 16 commits into from
Sep 25, 2024

Conversation

@thecoolwinter
Copy link
Collaborator

@thecoolwinter thecoolwinter commented Sep 17, 2024 •
edited
Loading

Description

Defers app termination until we've terminated all child processes (tasks and language servers). This ensures when CodeEdit is quit all related processes are terminated as well.

Related Issues

  • N/A

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

@thecoolwinter thecoolwinter marked this pull request as draft September 17, 2024 21:15
@thecoolwinter thecoolwinter added workspace language server Issues or Pull Requests related to language servers. labels Sep 18, 2024
@thecoolwinter thecoolwinter marked this pull request as ready for review September 19, 2024 14:35
tom-ludwig
tom-ludwig requested changes Sep 21, 2024
View reviewed changes
@thecoolwinter @tom-ludwig
Use SIGTERM Over SIGINT
38b0d39 
Co-authored-by: Tom Ludwig <[email protected]>
tom-ludwig
tom-ludwig previously approved these changes Sep 24, 2024
View reviewed changes
0xWDG
0xWDG previously approved these changes Sep 24, 2024
View reviewed changes
FastestMolasses
FastestMolasses requested changes Sep 24, 2024
View reviewed changes
@thecoolwinter thecoolwinter dismissed stale reviews from 0xWDG and tom-ludwig via d585370 September 24, 2024 14:16
0xWDG
0xWDG approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@0xWDG 0xWDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@thecoolwinter thecoolwinter merged commit e4f03fe into CodeEditApp:main Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xWDG 0xWDG 0xWDG approved these changes

@FastestMolasses FastestMolasses FastestMolasses approved these changes

@austincondiff austincondiff Awaiting requested review from austincondiff

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

@bombardier200 bombardier200 Awaiting requested review from bombardier200

@tom-ludwig tom-ludwig Awaiting requested review from tom-ludwig

Assignees

No one assigned

Labels

language server Issues or Pull Requests related to language servers. workspace

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thecoolwinter @0xWDG @FastestMolasses @tom-ludwig