feat: observe directory changes with publisher #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Please fix merge conflicts. Great work! |
MarcoCarnevali
force-pushed
the
feature/directory-publisher
branch
from
75a9066 to
3abb4dc
Compare
Collaborator
|
We are again out of sync due to a fix needing to be merged in |
MarcoCarnevali
force-pushed
the
feature/directory-publisher
branch
2 times, most recently
from
0feb8ef to
afaf0ff
Compare
MarcoCarnevali
force-pushed
the
feature/directory-publisher
branch
from
afaf0ff to
2b6b7af
Compare
lukepistrol
pushed a commit
to lukepistrol/CodeEdit
that referenced
this pull request
Mar 17, 2022
(cherry picked from commit d4d14bf)
xinix909
pushed a commit
to xinix909/CodeTransfer
that referenced
this pull request
Sep 7, 2024
…odeEditApp#696) (CodeEditApp#144) # Description <!--- REQUIRED: Describe what changed in detail --> * In `STTextViewController.swift`, the `setCursorPosition` function was changed so that, if the currently open file is empty, the cursor is automatically set to the first position and active. This behavior is similar to other text editors e.g. VSCode. A related PR is opened in CodeEdit, which works in tandem with this one, so that newly-created files automatically open in a new editor tab. # Related Issue <!--- REQUIRED: Tag all related issues (e.g. * CodeEditApp#23) --> * [CodeEditApp#696](CodeEditApp#696) from CodeEdit. * PR [CodeEditApp#1057](CodeEditApp#1057) from CodeEdit. # Checklist <!--- Add things that are not yet implemented above --> - [x] I read and understood the [contributing guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md) as well as the [code of conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md) - [x] My changes generate no new warnings - [x] My code builds and runs on my machine - [x] I documented my code - [x] Review requested # Screenshots
xinix909
pushed a commit
to xinix909/CodeTransfer
that referenced
this pull request
Sep 7, 2024
…pp#23) ### Description - Reduces text drawing artifacts by turning off font smoothing, enabling subpixel positioning and font quantization, and a hidden smoothing API. - Adds an internal ObjC target to accomplish the previous point. - Fixes a layout bug where layout bounds would be nearly infinite due to the view being told to lay out but not be in the view hierarchy yet, causing a hang and memory explosion as every line in a potentially large document is laid out and rendered. - Fixes a small bug with the undo manager's grouping behavior and makes it public (for a fix in CESE for undo-redo related bugs), as well as reordering some notifications in the undo manager. ### Related Issues * N/A ### Checklist - [x] I read and understood the [contributing guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md) as well as the [code of conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md) - [x] The issues this PR addresses are related to each other - [x] My changes generate no new warnings - [x] My code builds and runs on my machine - [x] My changes are all related to the related issue above - [x] I documented my code ### Screenshots Before: <img width="314" alt="Screenshot 2024-02-12 at 2 03 35 PM" src="https://github.com/CodeEditApp/CodeEditTextView/assets/35942988/b4f3b3ae-0eb7-4e0b-bde8-df0b7c8fcc65"> After (left CE, right Xcode): 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the response of the
WorkspaceClientgetFiles()API. Instead of returning an array of files it now returns a CombinePublisherwhich publish the list of files anytime there is a change on the directory. This is useful so that the sidebar is always up-to-date with the selected directory.Screen.Recording.2022-03-17.at.08.55.52.mov