Skip to content

Conversation

@thecoolwinter
Copy link
Contributor

Description

Fixes a bug that made lines ending with the carriage return line feed (\r\n) string be typeset incorrectly, adding an extra visible line when one did not exist.

Also adds a few simple tests to avoid regression.

Related Issues

  • N/A

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Copy link
Member

@FastestMolasses FastestMolasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thecoolwinter thecoolwinter merged commit f2f9d93 into CodeEditApp:main Feb 15, 2024
@tom-ludwig
Copy link
Member

@thecoolwinter even though this is already merged, why did you disable Swiftlint for testing?

@thecoolwinter
Copy link
Contributor Author

I often disable it for test files because test files can become long or require long lines for test input. It wasn't necessary here in hindsight. I'll remove it in a future PR to keep things more clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants