Remove Problematic CATransaction, Fix Lines Disappearing

[thecoolwinter]

Description

Fixes a bug where line fragment views were being removed from layout despite the lines still existing. This was caused by overlapping layoutLines calls in the layout manager, which in turn were caused by a CATransaction.commit() call. This transaction was unnecessary and was removed.

When commit() was called, the text view's NSView.layout method was triggered, causing layout again starting in the middle of the existing layout pass. However, the layout is not reentrant and this caused some line fragment views to be marked as missing and subsequently removed.

To prevent errors similar to this in the future, a debug-only flag was added during layout and is asserted when layout begins.

Related Issues

• closes 🐞 Two carriage returns will cause the text to disappear #47
• 🐞 Text was accidentally hidden when the Enter key was pressed #48, not sure if this closes it but it looks like it might be similar after the changes in Fix Marked Text Input #40.
• closes 🐞 Carriage return problems: Editor puts lines to blank as carriage return is pressed multiple times CodeEdit#1897

Checklist

• I read and understood the contributing guide as well as the code of conduct
• The issues this PR addresses are related to each other
• My changes generate no new warnings
• My code builds and runs on my machine
• My changes are all related to the related issue above
• I documented my code

Screenshots

Screen.Recording.2024-10-12.at.1.27.13.PM.mov