scssPHP 1.5.2 & update deprecations #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@stof Actually seemed like this was pretty straightforward to update. Thoughts? Things I might have missed? |
stof
reviewed
May 31, 2021
stof
left a comment
stof
left a comment
There was a problem hiding this comment.
You are still using the compile() method and not the new compileString() API.
Be careful though when migrating. When using SOURCE_MAP_FILE, the new API does not write the sourcemap to disk (just like the compiler never wrote the CSS to disk). The content of the source map will be available in the returned CompilationResult object.
Collaborator
Author
|
@stof, Ok. I think I got the compileString() working. |
stof
reviewed
May 31, 2021
stof
reviewed
Jun 1, 2021
…tThink/WP-SCSS into scssPHP-1.5.2-update-deprications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.