[@types/node] Update type definitions for v20.12.2 #69212

ghost · 2024-03-30T14:36:37Z

Please fill in this template.

Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change.
Follow the advice from the readme.
Avoid common mistakes.
Run pnpm test node.

If changing an existing definition:

Provide a URL to documentation or source code which provides context for the suggested changes: https://nodejs.org/en/blog/release/v20.12.0
If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

PodaruDragos · 2024-04-04T09:37:06Z

Will this PR also include loadEnvFile ?
Or is that something that will come later ?

ghost · 2024-04-04T10:06:41Z

Will this PR also include loadEnvFile ? Or is that something that will come later ?

Already added in #68940

mangs

Thank you for these changes. I left a tweak to the types for styleText that I think would be helpful. Curious of your thoughts.

types/node/util.d.ts

types/node/process.d.ts

typescript-bot · 2024-04-07T14:11:42Z

@codershiba Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

node — on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 69212,
  "author": "codershiba",
  "headCommitOid": "50bd697deb92061a65ed76ecacf72d4f6a1ed8e5",
  "mergeBaseOid": "15c1836f89521ddd11574ef04793c1675de86a9d",
  "lastPushDate": "2024-03-30T14:36:37.000Z",
  "lastActivityDate": "2024-05-01T18:25:38.000Z",
  "mergeOfferDate": "2024-05-01T17:41:19.000Z",
  "mergeRequestDate": "2024-05-01T18:25:38.000Z",
  "mergeRequestUser": "codershiba",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/assert.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/async_hooks.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/buffer.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/child_process.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/cluster.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/console.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/crypto.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/dgram.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/diagnostics_channel.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/dns.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/domain.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/events.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/fs.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/fs/promises.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/http.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/http2.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/https.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/inspector.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/net.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/os.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/path.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/perf_hooks.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/process.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/punycode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/querystring.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/readline.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/readline/promises.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/repl.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/stream.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/stream/web.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/string_decoder.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/test.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/test/crypto.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/http2.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/process.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/util.ts",
          "kind": "test"
        },
        {
          "path": "types/node/timers.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/timers/promises.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/tls.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/trace_events.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/tty.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/url.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/util.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v8.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/vm.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/wasi.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/worker_threads.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/zlib.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Microsoft",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "galkin",
        "parambirs",
        "eps1lon",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "peterblazejewicz",
        "addaleax",
        "victorperin",
        "ZYSzys",
        "NodeJS",
        "LinusU",
        "wafuwafu13",
        "mcollina",
        "Semigradsky"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2024-05-01T17:26:29.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "Anonymous4078",
      "date": "2024-04-27T11:16:30.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "andrewbranch",
      "date": "2024-04-26T16:52:11.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "smartinio",
      "date": "2024-04-26T14:40:02.000Z",
      "isMaintainer": false
    },
    {
      "type": "stale",
      "reviewer": "mangs",
      "date": "2024-04-08T15:20:50.000Z",
      "abbrOid": "352782b"
    }
  ],
  "mainBotCommentID": 2041483998,
  "ciResult": "pass"
}

typescript-bot · 2024-04-07T14:11:44Z

🔔 @microsoft @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

typescript-bot · 2024-04-07T14:28:36Z

@smartinio, @mangs Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

types/node/async_hooks.d.ts

types/node/vm.d.ts

typescript-bot · 2024-04-07T17:41:56Z

@mangs Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

typescript-bot · 2024-04-10T19:04:25Z

Re-ping @microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

andrewbranch

Thank you! I noticed just a couple things to take another look at.

types/node/crypto.d.ts

types/node/test.d.ts

typescript-bot · 2024-04-26T14:38:33Z

@codershiba The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

Anonymous4078 · 2024-05-01T08:50:04Z

Please merge I need this

Anonymous4078 · 2024-05-01T08:52:07Z

Any ETA??

DangerBotOSS · 2024-05-01T17:40:34Z

Formatting

The following files are not formatted:

types/node/zlib.d.ts
types/node/tls.d.ts
types/node/crypto.d.ts
types/node/trace_events.d.ts
types/node/assert.d.ts

Consider running pnpm dprint fmt on these files to make review easier.

Generated by 🚫 dangerJS against 50bd697

typescript-bot · 2024-05-01T17:41:14Z

@codershiba: Everything looks good here. I am ready to merge this PR (at 50bd697) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky: you can do this too.)

typescript-bot · 2024-05-01T17:41:15Z

@mangs Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

typescript-bot · 2024-05-01T17:41:19Z

@codershiba: Everything looks good here. I am ready to merge this PR (at 50bd697) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky: you can do this too.)

typescript-bot · 2024-05-01T17:41:19Z

@mangs Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

ghost · 2024-05-01T18:25:38Z

Ready to merge

This was referenced Mar 30, 2024

[node]: Add typing for util.styleText #69209

Closed

[@types/node] Add util.styleText function #69259

Closed

[node] Add hash method to crypto module #69236

Closed

steffen-4s1 mentioned this pull request Apr 4, 2024

util.styleText(): Combining multiple styles in a single string? nodejs/node#52035

Closed

mangs reviewed Apr 5, 2024

View reviewed changes

types/node/util.d.ts Outdated Show resolved Hide resolved

ghost requested a review from mangs April 6, 2024 13:35

smartinio reviewed Apr 7, 2024

View reviewed changes

types/node/process.d.ts Outdated Show resolved Hide resolved

ghost marked this pull request as ready for review April 7, 2024 14:11

ghost requested review from eps1lon and peterblazejewicz as code owners April 7, 2024 14:11

ghost requested a review from smartinio April 7, 2024 14:11

typescript-bot added the Critical package label Apr 7, 2024

smartinio reviewed Apr 7, 2024

View reviewed changes

types/node/async_hooks.d.ts Outdated Show resolved Hide resolved

types/node/vm.d.ts Outdated Show resolved Hide resolved

ghost marked this pull request as draft April 7, 2024 16:46

ghost requested a review from smartinio April 7, 2024 17:27

ghost marked this pull request as ready for review April 7, 2024 17:27

smartinio approved these changes Apr 7, 2024

View reviewed changes

typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label Apr 7, 2024

ghost changed the title ~~[@types/node] Update type definitions for v20.12.0~~ [@types/node] Update type definitions for v20.12.1 Apr 7, 2024

Anonymous4078 approved these changes Apr 8, 2024

View reviewed changes

mangs approved these changes Apr 8, 2024

View reviewed changes

typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Apr 10, 2024

andrewbranch reviewed Apr 16, 2024

View reviewed changes

types/node/crypto.d.ts Show resolved Hide resolved

types/node/test.d.ts Outdated Show resolved Hide resolved

smartinio approved these changes Apr 26, 2024

View reviewed changes

typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label Apr 26, 2024

andrewbranch approved these changes Apr 26, 2024

View reviewed changes

typescript-bot added the Maintainer Approved label Apr 26, 2024

Anonymous4078 approved these changes Apr 27, 2024

View reviewed changes

jakebailey closed this May 1, 2024

jakebailey reopened this May 1, 2024

jakebailey approved these changes May 1, 2024

View reviewed changes

typescript-bot added The CI failed When GH Actions fails and removed The CI failed When GH Actions fails labels May 1, 2024

jakebailey mentioned this pull request May 1, 2024

[kap-plugin] Use correct version of electron-store #69486

Merged

jakebailey closed this May 1, 2024

jakebailey reopened this May 1, 2024

jakebailey approved these changes May 1, 2024

View reviewed changes

typescript-bot removed the The CI failed When GH Actions fails label May 1, 2024

typescript-bot added the Self Merge This PR can now be self-merged by the PR author or an owner label May 1, 2024

typescript-bot merged commit 1e0b2d0 into DefinitelyTyped:master May 1, 2024

ghost deleted the update-node-lts branch May 1, 2024 18:26

mangs mentioned this pull request May 1, 2024

Remove util.styleText type overrides because @types/node has them now oven-sh/bun#10746

Merged

2 tasks

karlhorky mentioned this pull request May 2, 2024

crypto: implement crypto.hash() nodejs/node#51044

Closed

[@types/node] Update type definitions for v20.12.2 #69212

[@types/node] Update type definitions for v20.12.2 #69212

Uh oh!

Conversation

ghost commented Mar 30, 2024 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PodaruDragos commented Apr 4, 2024

Uh oh!

ghost commented Apr 4, 2024 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mangs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

typescript-bot commented Apr 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

1 package in this PR

Code Reviews

Status

Uh oh!

typescript-bot commented Apr 7, 2024

Uh oh!

typescript-bot commented Apr 7, 2024

Uh oh!

Uh oh!

Uh oh!

typescript-bot commented Apr 7, 2024

Uh oh!

typescript-bot commented Apr 10, 2024

Uh oh!

andrewbranch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

typescript-bot commented Apr 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Anonymous4078 commented May 1, 2024

Uh oh!

Anonymous4078 commented May 1, 2024

Uh oh!

DangerBotOSS commented May 1, 2024

Formatting

Uh oh!

typescript-bot commented May 1, 2024

Uh oh!

typescript-bot commented May 1, 2024

Uh oh!

typescript-bot commented May 1, 2024

Uh oh!

typescript-bot commented May 1, 2024

Uh oh!

ghost commented May 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ghost commented Mar 30, 2024 •

edited by ghost

Loading

ghost commented Apr 4, 2024 •

edited by ghost

Loading

typescript-bot commented Apr 7, 2024 •

edited

Loading

typescript-bot commented Apr 26, 2024 •

edited

Loading