Skip to content

Add React version number to profiling marks #35

@taneliang

Description

@taneliang

Context

@bvaughn at #5 (comment):

Since we are actively changing the "lanes" implementation and what the semantic value of a given lane is (e.g. facebook#19287) it would be helpful for us to encode some info in our profile that lets us match this information up later.

I had been thinking about eventually encoding what the lanes ranges are, so we could display some meaningful label in the profiler, but maybe that would be a hassle and for now- we could get away with just marking the version of React the profiling data corresponds to. This would let us at least manually match the lanes up later if we wanted to dig in deeper.

TODO

  • Decide where to put the version number:
    • On profile start: ideal, but we don't yet know if/how we can detect the start of a profile
    • In all marks: called way too often and is thus wasteful
    • In commit-start: called too often
    • In render-scheduled: called too rarely, e.g. on page load
  • Add that version number

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions