wxGUI/dbmgr: fix removing map table layer and layer related Browse data and Manage tables page (tab)

[tmszi]

Describe the bug
Removing map table layer don't work and related layer page (tab) on the Browse data and Manage tables page (tab) aren't deleted too.

To Reproduce
Steps to reproduce the behavior:

1. Launch Attribute Table Manager e.g g.gui.dbmgr geology
2. Switch to Manage layers page (tab)
3. Create new table with name e.g. test (right side on the Add layer page (tab))
4. Add new layer with layer number 2, and choose test table from table choice widget and hit Add layer button
5. On the Manage layers page (tab) switch to Remove layer page (tab)
6. Choose layer 2 from Layer to remove ComboBox widget choices and hit Remove layer button
7. See error

Traceback (most recent call last):
  File "/usr/lib64/grass83/gui/wxpython/dbmgr/base.py", line 3815, in OnDeleteLayer
    self.parentDialog.parentDbMgrBase.UpdateDialog(layer=layer)
  File "/usr/lib64/grass83/gui/wxpython/dbmgr/manager.py", line 253, in UpdateDialog
    DbMgrBase.UpdateDialog(self, layer=layer)
  File "/usr/lib64/grass83/gui/wxpython/dbmgr/base.py", line 860, in UpdateDialog
    self.pages["browse"].DeletePage(layer)
  File "/usr/lib64/grass83/gui/wxpython/dbmgr/base.py", line 1037, in DeletePage
    self.selLayer = self.layers[self.GetSelection()]
IndexError: list index out of range

Expected behavior
Removing map table layer should be work without error message, and related layer page (tab) on the Browse data and Manage tables page (tab) be deleted too.

System description (please complete the following information):

• Operating System: all
• GRASS GIS version: all

[petrasovaa]

Could you please comment on this more? The new code uses directly the method of the FlatNotebook, but why? Is something wrong about GNotebook's implementation? Wouldn't it be possibly better to adjust the code of this function to work with the GNotebook's version of DeletNBPage?

[tmszi]

NotebookController base class, InsertPage method has 2 way how to insert page:

grass/gui/wxpython/gui_core/widgets.py

Lines 143 to 154 in 120f198

	def InsertPage(self, *args, **kwargs):
	"""Insert a new page"""
	if "name" in kwargs:
	self.notebookPages[kwargs["name"]] = kwargs["page"]
	del kwargs["name"]
	try:
	self.classObject.InsertPage(self.widget, *args, **kwargs)
	except TypeError as e: # documentation says 'index', but certain versions of wx require 'n'
	kwargs["n"] = kwargs["index"]
	del kwargs["index"]
	self.classObject.InsertPage(self.widget, *args, **kwargs)

1. Insert page with name param
2. Insert page without name param (this is preferred way in Attribute Table Manager code)
   

   grass/gui/wxpython/dbmgr/base.py

   Lines 1173 to 1178 in 120f198

   	self.InsertNBPage(
   	index=pos,
   	page=panel,
   	text=" %d / %s %s"
   	% (layer, label, self.dbMgrData["mapDBInfo"].layers[layer]["table"]),
   	)

NotebookController base class, inside DeletePage method is called method GetPageIndexByName which is not return page index (return -1) if page was inserted without name param.

grass/gui/wxpython/gui_core/widgets.py

Lines 156 to 169 in 120f198

	def DeletePage(self, page):
	"""Delete page
	:param page: name
	:return: True if page was deleted, False if not exists
	"""
	delPageIndex = self.GetPageIndexByName(page)
	if delPageIndex != -1:
	ret = self.classObject.DeletePage(self.widget, delPageIndex)
	if ret:
	del self.notebookPages[page]
	return ret
	else:
	return False

FlatNotebookController class, GetPageIndexByName method

grass/gui/wxpython/gui_core/widgets.py

Lines 258 to 264 in 120f198

	def GetPageIndexByName(self, page):
	"""Get notebook page index
	:param page: name
	"""
	if page not in self.notebookPages:
	return -1

GNotebook class, method DeleteNBPage implementation allow delete page which was inserted with name param only.

[tmszi]

Rebase 327d334.

[tmszi]

@petrasovaa I refactored the use of InsertNBPage() (method use name param arg) method inside wxGUI/dbmgr component. Now DeleteNBPage() works as expected. Tested succesfully as usual.

[tmszi]

Wouldn't it be possibly better to adjust the code of this function to work with the GNotebook's version of DeletNBPage?

With 086b5b2 I refactor GetPageIndexByName() method of FlatNotebookController and of NotebookController class to meet your suggention. It is now possible to delete a notebook page by name or by page index position depending on how the page was added or inserted.

[petrasovaa]

Thank you, I think this is better!