Skip to content

Conversation

@metzm
Copy link
Contributor

@metzm metzm commented Jun 27, 2022

The PJ_AREA has not been properly estimated. As a result, sometimes the wrong PROJ pipeline was chosen, or PROJ failed to find a pipeline at all.

@metzm metzm added bug Something isn't working backport_needed C Related code is in C labels Jun 27, 2022
@metzm metzm added this to the 8.2.1 milestone Jun 27, 2022
@metzm metzm merged commit da18254 into OSGeo:main Jun 30, 2022
@metzm metzm deleted the v.proj_authcode branch June 30, 2022 14:21
metzm added a commit that referenced this pull request Jun 30, 2022
* fix area bbox for PROJ
* add tests for valid area bbox
* test if crossing the anti-meridian
metzm added a commit that referenced this pull request Jun 30, 2022
* fix area bbox for PROJ
* add tests for valid area bbox
* test if crossing the anti-meridian
metzm added a commit that referenced this pull request Jun 30, 2022
* fix area bbox for PROJ
* add tests for valid area bbox
* test if crossing the anti-meridian
@wenzeslaus
Copy link
Member

This also fixes a segmentation fault in v.proj with --verbose reported by valgrind as:

==825924== Conditional jump or move depends on uninitialised value(s)
==825924==    at 0x4857D5E: pj_print_proj_params (get_proj.c:538)
==825924==    by 0x10B32C: main (main.c:205)

The fix is the move of the following lines (info_in was not initialized):

if (G_verbose() == G_verbose_max()) {
    pj_print_proj_params(&info_in, &info_out);
}

Thanks!

Workaround is (before 8.2.1 and/or 8.3.0): Don't use verbose mode with v.proj or with whatever calls v.proj (notably, r.import and v.import).

ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
* fix area bbox for PROJ
* add tests for valid area bbox
* test if crossing the anti-meridian
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
* fix area bbox for PROJ
* add tests for valid area bbox
* test if crossing the anti-meridian
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
* fix area bbox for PROJ
* add tests for valid area bbox
* test if crossing the anti-meridian
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working C Related code is in C

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants