g.mapsets: Add JSON output

[cwhite911]

Preparing module to add json output to g.mapsets.

[nilason]

Greatly appreciate your work with JSON output!
I added some comments/suggestions.

A more general suggestion is to limit comments to where they really are helpful, not commenting every step in the code. If the code is good written it is usually self-explanatory.

[cwhite911]

Thanks for the feedback @nilason!

A more general suggestion is to limit comments to where they really are helpful, not commenting every step in the code. If the code is good written it is usually self-explanatory.

I intentionally overloaded this with comments to kind of serve as documentation for parson library.

[nilason]

Thanks for the feedback @nilason!

A more general suggestion is to limit comments to where they really are helpful, not commenting every step in the code. If the code is good written it is usually self-explanatory.

I intentionally overloaded this with comments to kind of serve as documentation for parson library.

If parson library would have a cryptic API with acronyms of dropped vowels I would perhaps agree with the need for that. Parson API is however very descriptive, e.g.:

// Serialize root object to string and print it to stdout
serialized_string = json_serialize_to_string_pretty(root_value);
puts(serialized_string);

...the comment does not add anything new compared to just reading the code. That is what I mean by self-explanatory code.

Another example:

// Free memory
json_free_serialized_string(serialized_string);
json_value_free(root_value);

We shouldn't underestimate our potential contributors, I would presume there is at the very minimum a basic knowledge of C. The code without the comments, would perfectly work as a good example.

[cwhite911]

@nilason I removed some of the extra comments like you suggested and refactored the code to be dryer creating the json.

[nilason]

Great!

Outdated and resolved