modules: fix parallelized raster modules for buffer sizes #3070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metzm
added
bug
petrasovaa
approved these changes
Jul 7, 2023
wenzeslaus
reviewed
Jul 13, 2023
metzm
added a commit
that referenced
this pull request
Sep 3, 2023
* parallelized raster modules: fix buffer sizes * safety check for unsigned integer subtraction
landam
pushed a commit
to landam/grass
that referenced
this pull request
Oct 25, 2023
* parallelized raster modules: fix buffer sizes * safety check for unsigned integer subtraction
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
* parallelized raster modules: fix buffer sizes * safety check for unsigned integer subtraction
neteler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the parallelization of various raster modules, a memory option for a new output buffer was introduced. The calculation of the number of buffered rows did not take into account that a potentially large amount of RAM is already used for input data. This PR adjusts the calculation of the number of rows to be buffered for output maps for the modules
r.neighbors,r.patch,r.resamp.filter, andr.series, avoiding accidental OOM errors. These modules should now use not (much) more than the user-specified amount of RAM.