Skip to content

r.fillnulls: proceed if no holes present (RST method) #3122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
neteler merged 1 commit into from
Aug 14, 2023
Merged

r.fillnulls: proceed if no holes present (RST method) #3122

neteler merged 1 commit into from
Aug 14, 2023

Conversation

@neteler
Copy link
Member

@neteler neteler commented Aug 13, 2023

Proceed if no holes present also for rst method - now all methods behave the same.

In case no holes are in the current region of the raster input map the map is copied over and no fatal error is issues (same for all methods).

Test case:

# GRASS nc_spm_08_grass7/user1
g.region raster=elevation -p
# bilinear
r.fillnulls input=elevation output=test method=bilinear
# rst: this should no longer end with fatal error
r.fillnulls input=elevation output=test method=rst

Fixes #2986

@neteler
r.fillnulls: proceed if no holes present (RST method)
3ada801 
Proceed if no holes present also for `rst` method - now all methods behave the same.

In case no holes are in the current region of the raster input map the map is copied over and no fatal error is issues (same for all methods).

Fixes #2986
@neteler neteler added enhancement New feature or request backport to 8.3 labels Aug 13, 2023
@neteler neteler added this to the 8.4.0 milestone Aug 13, 2023
@neteler neteler self-assigned this Aug 13, 2023
@neteler neteler merged commit 43b3409 into OSGeo:main Aug 14, 2023
@neteler neteler deleted the r_fillnulls_rst_noholes branch August 14, 2023 14:51
neteler added a commit that referenced this pull request Aug 14, 2023
@neteler
r.fillnulls: proceed if no holes present (RST method) (#3122)
9c16c06 
Proceed if no holes present also for `rst` method - now all methods behave the same.

In case no holes are in the current region of the raster input map the map is copied over and no fatal error is issues (same for all methods).

Fixes #2986
@neteler neteler modified the milestones: 8.4.0, 8.3.1 Aug 14, 2023
landam pushed a commit to landam/grass that referenced this pull request Oct 25, 2023
@neteler @landam
r.fillnulls: proceed if no holes present (RST method) (OSGeo#3122)
9fbf591 
Proceed if no holes present also for `rst` method - now all methods behave the same.

In case no holes are in the current region of the raster input map the map is copied over and no fatal error is issues (same for all methods).

Fixes OSGeo#2986
neteler added a commit to nilason/grass that referenced this pull request Nov 7, 2023
@neteler
r.fillnulls: proceed if no holes present (RST method) (OSGeo#3122)
2142e0c 
Proceed if no holes present also for `rst` method - now all methods behave the same.

In case no holes are in the current region of the raster input map the map is copied over and no fatal error is issues (same for all methods).

Fixes OSGeo#2986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marisn marisn marisn approved these changes

Assignees

@neteler neteler

Labels

enhancement New feature or request

Projects

None yet

Milestone

8.3.1

Development

Successfully merging this pull request may close these issues.

[Bug] r.fillnulls reports "Input map has no holes" with method=rst

2 participants

@neteler @marisn