r.horizon: address incorrect number of rasters created #3411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
raster
wenzeslaus
approved these changes
Feb 16, 2024
Member
wenzeslaus
left a comment
wenzeslaus
left a comment
There was a problem hiding this comment.
This is indeed how it should behave. Thanks!
Contributor
|
Thanks, Anna! |
Member
|
@petrasovaa Is this a backport candidate for G8.3? |
Contributor
Author
No |
jadenabrams100
pushed a commit
to ncsu-csc472-spring2024/grass-CI-playground
that referenced
this pull request
Feb 21, 2024
E.g. for start=0, end=12, step=5, three rasters are now generated (0, 5, 10) and not only 2 (because 12/5 = 2...) as was the case before.This also speeds up the test significantly, there was no need to run r.horizon with full resolution if we are checking only the created raster names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2582.
E.g. for start=0, end=12, step=5, three rasters are now generated (0, 5, 10) and not only 2 (because 12/5 = 2...) as was the case before.
Documentation is still valid, the interval is [start, end) as described there. Not sure if this should be backported, it is a bugfix, but it could break things (e.g. in QGIS, see the link in #2582).
This also speeds up the test significantly, there was no need to run r.horizon with full resolution if we are checking only the created raster names.