vector: use full db connection settings for db.describe #3462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metzm
added
bug
wenzeslaus
approved these changes
Feb 28, 2024
Member
wenzeslaus
left a comment
wenzeslaus
left a comment
There was a problem hiding this comment.
The changes look good and all three tools have tests. Thanks!
metzm
added a commit
that referenced
this pull request
Feb 28, 2024
fix `db.dropcolumn`, `db.in.ogr`, `v.db.renamecolumn`
Contributor
Author
|
Backported to G83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some scripts did not specify database and driver when calling
grass.db_describe(), causing errors if vector maps use non-standard db connections. This PR queries actual db connection settings for affected modules and passes these tograss.db_describe()