r.horizon: fix distance output #3589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
raster
wenzeslaus
approved these changes
Apr 18, 2024
Member
wenzeslaus
left a comment
wenzeslaus
left a comment
There was a problem hiding this comment.
My understanding is that the variable was used in two different contexts and that's now untangled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes recently added support (#3565) for exporting distances together with horizon angles. The distance (
horizon.length) needs to be saved when the angle is computed, it was growing during horizon search while the angle stayed the same. To clarify, this fixes newly created problem, it doesn't impact the angle computations.