r.sim.water: fix logfile writing #4522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrasovaa
added
bug
wenzeslaus
approved these changes
Oct 14, 2024
github-actions
bot
added
raster
|
Built from https://github.com/petrasovaa/grass/tree/r.sim.water-fix and tested on Ubuntu 24.04. Log file now being output and errors as expected Thank you @petrasovaa |
petrasovaa
added a commit
that referenced
this pull request
Oct 15, 2024
petrasovaa
removed
the
backport to 8.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4511. Previously, user input was not being passed to the library. I also fixed the documentation for r.sim.water.
I removed
create_observation_points()because it's already ininput_data():grass/raster/r.sim/simlib/input.c
Line 385 in 61b380f
I tested both r.sim.water and r.sim.sediment and the log file content seem to make sense.