Skip to content

Conversation

@nilason
Copy link
Contributor

@nilason nilason commented Feb 13, 2025

Pin gdal-grass driver to version 1.0.3 and add cmake package to Alpine.

@nilason nilason added the backport to 8.4 PR needs to be backported to release branch 8.4 label Feb 13, 2025
@nilason nilason added this to the 8.5.0 milestone Feb 13, 2025
@github-actions github-actions bot added the docker Docker related label Feb 13, 2025
@echoix
Copy link
Member

echoix commented Feb 13, 2025

And for the record, the preset is indeed enabled in the renovate config:

grass/renovate.json5

Lines 8 to 15 in 1c1d01d

// allows using comments starting with
// "# renovate: " to update _VERSION
// environment variables in GitHub Action files.
"customManagers:githubActionsVersions",
// allows using comments starting with
// "# renovate: " to update _VERSION
// ENV or ARG in a Dockerfile.
"customManagers:dockerfileVersions",

@nilason nilason enabled auto-merge (squash) February 13, 2025 13:09
@nilason nilason merged commit 6b652b6 into OSGeo:main Feb 13, 2025
26 checks passed
@wenzeslaus
Copy link
Member

Still not quite there, on main for alpine:

2025-02-13T15:03:19.8590663Z #17 [build 9/9] RUN cmake -B build -DAUTOLOAD_DIR=/usr/lib/gdalplugins -DBUILD_TESTING=OFF &&     cmake --build build &&     cmake --install build
2025-02-13T15:03:19.8591791Z #17 0.052 CMake Error: The source directory "/src/gdal-grass" does not appear to contain CMakeLists.txt.
2025-02-13T15:03:19.8592636Z #17 0.052 Specify --help for usage, or press the help button on the CMake GUI.
2025-02-13T15:03:19.8593838Z #17 ERROR: process "/bin/sh -c cmake -B build -DAUTOLOAD_DIR=/usr/lib/gdalplugins -DBUILD_TESTING=OFF &&     cmake --build build &&     cmake --install build" did not complete successfully: exit code: 1
2025-02-13T15:03:19.8850378Z ------
2025-02-13T15:03:19.8851576Z  > [build 9/9] RUN cmake -B build -DAUTOLOAD_DIR=/usr/lib/gdalplugins -DBUILD_TESTING=OFF &&     cmake --build build &&     cmake --install build:
2025-02-13T15:03:19.8854888Z 0.052 CMake Error: The source directory "/src/gdal-grass" does not appear to contain CMakeLists.txt.
2025-02-13T15:03:19.8855825Z 0.052 Specify --help for usage, or press the help button on the CMake GUI.

We need that test job for PRs. Do we change build and Docker things in every PR? No, but we do change them often enough.

@echoix
Copy link
Member

echoix commented Feb 13, 2025

We need that test job for PRs. Do we change build and Docker things in every PR? No, but we do change them often enough.

The way that workflow is written, it is maybe not that safe to just add a different trigger as is.
Some changes are needed to make sure it isn't allowed to try to push when it is a PR.

@echoix
Copy link
Member

echoix commented Feb 13, 2025

Still not quite there, on main for alpine:


2025-02-13T15:03:19.8590663Z #17 [build 9/9] RUN cmake -B build -DAUTOLOAD_DIR=/usr/lib/gdalplugins -DBUILD_TESTING=OFF &&     cmake --build build &&     cmake --install build

2025-02-13T15:03:19.8591791Z #17 0.052 CMake Error: The source directory "/src/gdal-grass" does not appear to contain CMakeLists.txt.

2025-02-13T15:03:19.8592636Z #17 0.052 Specify --help for usage, or press the help button on the CMake GUI.

2025-02-13T15:03:19.8593838Z #17 ERROR: process "/bin/sh -c cmake -B build -DAUTOLOAD_DIR=/usr/lib/gdalplugins -DBUILD_TESTING=OFF &&     cmake --build build &&     cmake --install build" did not complete successfully: exit code: 1

2025-02-13T15:03:19.8850378Z ------

2025-02-13T15:03:19.8851576Z  > [build 9/9] RUN cmake -B build -DAUTOLOAD_DIR=/usr/lib/gdalplugins -DBUILD_TESTING=OFF &&     cmake --build build &&     cmake --install build:

2025-02-13T15:03:19.8854888Z 0.052 CMake Error: The source directory "/src/gdal-grass" does not appear to contain CMakeLists.txt.

2025-02-13T15:03:19.8855825Z 0.052 Specify --help for usage, or press the help button on the CMake GUI.

I think I know what's going on. The repo is cloned into src/gdal-grass and then the workdir is set to /src/gdal-grass. I think the repo is cloned relative to the working directory that was active when that step was run, and it isn't absolute. So, cmake runs in an empty directory tree.

@nilason nilason deleted the docker_gdal-grass2 branch February 13, 2025 22:28
nilason added a commit to nilason/grass that referenced this pull request Nov 17, 2025
nilason added a commit to nilason/grass that referenced this pull request Nov 18, 2025
nilason added a commit to nilason/grass that referenced this pull request Nov 18, 2025
nilason added a commit that referenced this pull request Nov 18, 2025
@nilason nilason modified the milestones: 8.5.0, 8.4.2 Nov 18, 2025
@nilason nilason removed the backport to 8.4 PR needs to be backported to release branch 8.4 label Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docker Docker related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants