Skip to content

Conversation

@nilason
Copy link
Contributor

@nilason nilason commented Feb 24, 2025

Use correct type of quotes for SQLite 3.49.0+.

Fixes #5197.

@nilason nilason added the backport to 8.4 PR needs to be backported to release branch 8.4 label Feb 24, 2025
@nilason nilason added this to the 8.5.0 milestone Feb 24, 2025
@github-actions github-actions bot added macOS macOS specific vector Related to vector data processing temporal Related to temporal data processing Python Related code is in Python module tests Related to Test Suite labels Feb 24, 2025
@nilason nilason added the bug Something isn't working label Feb 24, 2025
@nilason
Copy link
Contributor Author

nilason commented Feb 24, 2025

Now tests passes with SQLite 3.49.1.

@echoix echoix changed the title pytest: use correct type of quotes for SQLite 3.49.0+ pytest: use correct type of quotes for conda's SQLite 3.49.0+ (SQLITE_DQS=0) Feb 24, 2025
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, SQLite quirks document look like fun. Thanks for the fix.

@echoix echoix merged commit 9013c3d into OSGeo:main Feb 25, 2025
30 checks passed
@nilason nilason deleted the fix_sqlite_5197 branch February 25, 2025 11:27
nilason added a commit to nilason/grass that referenced this pull request Nov 17, 2025
nilason added a commit that referenced this pull request Nov 18, 2025
Use correct type of quotes for SQLite (manual, partial backport of #5199)

For Conda's SQLite 3.49.0+ (SQLITE_DQS=0)
@nilason nilason removed the backport to 8.4 PR needs to be backported to release branch 8.4 label Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working macOS macOS specific module Python Related code is in Python temporal Related to temporal data processing tests Related to Test Suite vector Related to vector data processing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat] Support SQLITE_DQS=0, disallow double quoted strings litterals

3 participants