r.surf.idw: fix SHORT overflow #6396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the limitation to 16 bits by replacing `short` type to `integer`.
Example (now fixed):
```bash
GRASS latlong_wgs84/mymapset:grass >
g.region vector=solar_panels_points -m
projection=3
zone=0
n=56.62055
s=47
w=5.451694
e=14.991018
nsres=30.9064117
ewres=19.07598674
rows=34634
cols=34342
cells=1189400828
```
One giga-pixels (34k x 34k) is not that much. Yet it overflowed:
```bash
r.surf.idw input=solar_panels output=heatmap_idw_rast
Current region rows: 34634, cols: 34342
ERROR: G_calloc: unable to allocate 18446744073709520714 * 40 bytes of
memory at raster/r.surf.idw/dist.c:43
```
This PR fixes this limitation.
Co-authored-by: @metzm
neteler
added
bug
nilason
approved these changes
Sep 23, 2025
Contributor
nilason
left a comment
nilason
left a comment
There was a problem hiding this comment.
Looks good to me!
(Wonder why using short in the first place).
Member
Author
Guess it stems from very old times: it is already in the code snippet from > 20 years ago: |
Contributor
Seems like yesterday :). I suspected that was the reason. |
neteler
removed
the
backport to 8.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the limitation to 16 bits by replacing
shorttype tointeger.Example (now fixed):
GRASS latlong_wgs84/mymapset:grass > g.region vector=solar_panels_points -m projection=3 zone=0 n=56.62055 s=47 w=5.451694 e=14.991018 nsres=30.9064117 ewres=19.07598674 rows=34634 cols=34342 cells=1189400828One giga-pixels (34k x 34k) is not that much. Yet it overflowed:
r.surf.idw input=solar_panels output=heatmap_idw_rast Current region rows: 34634, cols: 34342 ERROR: G_calloc: unable to allocate 18446744073709520714 * 40 bytes of memory at raster/r.surf.idw/dist.c:43This PR fixes this limitation.
Co-authored-by: @metzm