Skip to content

Conversation

@neteler
Copy link
Member

@neteler neteler commented Sep 25, 2025

This PR is a minimalistic flake8 settings backport to re-enable pre-commit and CI in relbranch84.

This PR is a minimalistic flake8 backport to re-enable pre-commit and CI in relbranch84.
@neteler neteler added this to the 8.4.2 milestone Sep 25, 2025
@neteler neteler self-assigned this Sep 25, 2025
@neteler neteler added the CI Continuous integration label Sep 25, 2025
@github-actions github-actions bot added raster Related to raster data processing HTML Related code is in HTML module docs labels Sep 25, 2025
@echoix
Copy link
Member

echoix commented Sep 25, 2025

I finally got to cherry pick the commit you had problems with, so better to rebase this branch here, as there will probably be conflicts

@neteler
Copy link
Member Author

neteler commented Sep 25, 2025

I finally got to cherry pick the commit you had problems with

There are still CI errors:

run editorconfig-checker.................................................Failed
- hook id: editorconfig-checker
- exit code: 1

raster/r.reclass/testsuite/test_r_reclass.py:
	8-9: Wrong indent style found (tabs instead of spaces)
vector/v.extract/testsuite/test_v_extract.py:
	8-9: Wrong indent style found (tabs instead of spaces)

2 errors found
scripts/r.reclass.area/testsuite/testrra.py:
	8-9: Wrong indent style found (tabs instead of spaces)
	...

@echoix
Copy link
Member

echoix commented Sep 25, 2025

Yep, we've gone a long way since 8.4 in improving the quality.

When discussing offline, I mentioned some of the commits that fixed these issues before that change was made.

So, to also cherry pick (at least some parts of):

That's what I had found before, it might not be enough still for these issues

@neteler
Copy link
Member Author

neteler commented Sep 25, 2025

to also cherry pick (at least some parts of):

I am sorry, this is beyond my git skills (just messed up again my local copy)...

@wenzeslaus
Copy link
Member

...also disabling problematic checks is acceptable for older release branches, I would say, even if it means also disabling local pre-commit. Whatever is easier.

@echoix echoix merged commit 5620950 into OSGeo:releasebranch_8_4 Sep 25, 2025
24 of 25 checks passed
@neteler neteler deleted the ci_fix_flake8_g84 branch September 25, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous integration docs HTML Related code is in HTML module raster Related to raster data processing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants