docker: backport updates for Ubuntu 24.04 to releasebranch_8_4 #6540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoix
reviewed
Oct 24, 2025
| rm -rf /usr/local/grass84/share; \ | ||
| mkdir -p /usr/local/grass84/gui/wxpython/xml/; \ | ||
| mv module_items.xml /usr/local/grass84/gui/wxpython/xml/module_items.xml; | ||
| && rm -rf /usr/local/grass85/demolocation \ |
Member
There was a problem hiding this comment.
I think 85 should be 84 here, and for all other similar version-specific paths or names
| ENV CMAKE_BUILD_PARALLEL_LEVEL=$NUMTHREADS | ||
| WORKDIR /src | ||
|
|
||
| COPY ./utils/build_ubuntu_dependencies.sh /src/ |
Member
There was a problem hiding this comment.
Was the script backported outside this PR?
Member
|
We don't see the failures because the updated docker workflow from like a year ago (or a winter weather time ago), is probably not in that branch, because there wasn't a release yet. A local build in that branch, assuming no untracked files (or a clean tree, or fresh clone) should help see the errors |
Member
Author
|
Thanks for catching the glitches. Testing the build locally... |
echoix
reviewed
Oct 25, 2025
Member
echoix
left a comment
echoix
left a comment
There was a problem hiding this comment.
If your local build was fine, then it should be correct to go. We'll just have to monitor the Actions when they'll be merged
echoix
approved these changes
Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports the recent changes in the Ubuntu Dockerfiles, updating OS version to 24.04., here especially:
#6534
#6481
#6410