Refactor extensions code #1056
Merged
Refactor extensions code #1056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the extensions code by splitting the DscExtension implementation across separate files to improve code organization. No functional changes are made to the existing functionality.
Key changes:
- Split extension methods into capability-specific files
- Moved implementation code from
dscextension.rsto dedicated files - Added necessary imports to each new implementation file
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dsc_lib/src/extensions/dscextension.rs | Removed extension method implementations and helper functions, kept core struct definition |
| dsc_lib/src/extensions/discover.rs | Added discovery capability implementation with imports and helper code |
| dsc_lib/src/extensions/import.rs | Added import capability implementation with imports and helper code |
| dsc_lib/src/extensions/secret.rs | Added secret capability implementation with imports and helper code |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tgauth
approved these changes
Aug 18, 2025
SteveL-MSFT
pushed a commit
to SteveL-MSFT/DSC
that referenced
this pull request
Dec 1, 2025
Fix merge conflict ---- #### AI description (iteration 1) #### PR Classification This pull request is a preview release that refactors extension API implementations and improves build/CI processes. #### PR Summary The release reorganizes extension functionalities by moving the discover, import, and secret logic from a central file into dedicated modules, while enhancing build scripts and pipeline configuration for more robust releases. - `src/extensions/dscextension.rs`: Removed legacy implementations of extension methods (discover, import, secret) and their helper functions. - `src/extensions/import.rs`, `src/extensions/secret.rs`, `src/extensions/discover.rs`: Introduced modular implementations with corresponding helper functions to streamline extension handling. - `build.ps1` and tree-sitter build scripts: Improved error handling, verbose logging, and dependency installation checks. - CI pipeline files (e.g., `.pipelines/DSC-Official.yml`, `.pipelines/DSC-Windows.yml`, and `.cargo/config.toml`): Updated parameters, token references, and target/linker settings to support multi-architecture builds. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot --> Related work items: PowerShell#1056, PowerShell#1059
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Apparently Rust allows split implementations of a struct across files for a module. So moved all the extension specific code into separate files. No functional change.