Allow parameters to use secret() function #1079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@SteveL-MSFT up for grabs. It's a small one. |
michaeltlombardi
approved these changes
Aug 26, 2025
Collaborator
michaeltlombardi
left a comment
michaeltlombardi
left a comment
There was a problem hiding this comment.
Moving discovery of extensions earlier in the process makes sense to me - I think the number of cases where we'll need extensions before processing the document will only grow, such as if we eventually support extensions that provide configuration functions, or retrieving parameters from a remote key-value store, etc.
SteveL-MSFT
requested changes
Aug 28, 2025
Member
SteveL-MSFT
left a comment
SteveL-MSFT
left a comment
There was a problem hiding this comment.
This seems so obvious now, was a mistake before. Can you also add a test for variables?
Gijsreyn
force-pushed
the
allow-parameters-secret
branch
from
75e6a06 to
5e341bb
Compare
Contributor
Author
Don't worry, it can happen to all of us. Just added a test for the variable. Seeing if it succeeds and then it's ready to go :) |
SteveL-MSFT
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Initialization order changes before evaluating parameter defaults to allow parameters to use
secret()function.PR Context
Fix #1078