Fix/remote addr #232
Merged
Fix/remote addr #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalresistor
commented
Jan 26, 2019
| # Make sure that all IPv6 addresses are surrounded by brackets | ||
| # Make sure that all IPv6 addresses are surrounded by brackets, | ||
| # this is assuming that the IPv6 representation here does not | ||
| # include a port number. |
Member
Author
There was a problem hiding this comment.
https://tools.ietf.org/html/rfc5952#page-11 is a beast, and I am certainly not going to attempt to support every format out there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REMOTE_ADDRis inherited from the CGI spec, and it specifies that IP addresses should be placed inREMOTE_ADDR, and while IPv6 formatting allows for using brackets around the IP address, it is only generally done when you are also including the port number.The port number is in
REMOTE_PORT(if it exists) and thus the formatting with a bracket is not correct.Closes #230