interrupt the app_iter if it tries to write to a closed socket #238
+72
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmerickel
changed the title
mmerickel
force-pushed
the
close-app-iter-on-disconnect
branch
from
d4d8729 to
5a5418b
Compare
mmerickel
force-pushed
the
close-app-iter-on-disconnect
branch
from
5a5418b to
29fb97d
Compare
waitress/channel.py
Outdated
| if not self.connected: | ||
| # if the socket is closed then interrupt the task so that it | ||
| # can cleanup possibly before the app_iter is exhausted | ||
| # XXX a simple boolean check should not require a lock since it's |
Member
There was a problem hiding this comment.
s/XXX/NB/ and doing an if on a boolean here is safe in CPython, and probably other interpreters, and there is no race.
I don't think this comment is necessary to be honest.
| self.channel.write_soon(app_iter) | ||
| return | ||
|
|
||
| can_close_app_iter = True |
mmerickel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #236